Open
Conversation
Conan-Kudo
suggested changes
Dec 2, 2019
| FIND_PACKAGE (LZMA REQUIRED) | ||
| INCLUDE_DIRECTORIES (${LZMA_INCLUDE_DIR}) | ||
| FIND_PACKAGE (LibLZMA REQUIRED) | ||
| INCLUDE_DIRECTORIES (${LIBLZMA_INCLUDE_DIRS}) |
Member
There was a problem hiding this comment.
The LZMA "package" comes from the bundled FindLZMA.cmake that is in this repository.
Author
There was a problem hiding this comment.
FindLibLZMA is a part of CMake and is better because it populates the variables with info about the version. It is proposed to drop an own wheel and use the one shipped with CMake.
KOLANICH
force-pushed
the
liblzma_fixes
branch
from
e628aa9 to
1b6f028
Compare
KOLANICH
force-pushed
the
liblzma_fixes
branch
from
1b6f028 to
e62199f
Compare
Author
|
@mlschroe, @ignatenkobrain |
KOLANICH
force-pushed
the
liblzma_fixes
branch
from
e62199f to
a1f93f7
Compare
KOLANICH
force-pushed
the
liblzma_fixes
branch
from
a1f93f7 to
8fb225d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.