Skip to content

dllexport solv_version as well#379

Open
wolfv wants to merge 1 commit intoopenSUSE:masterfrom
wolfv:win_export_solv_version
Open

dllexport solv_version as well#379
wolfv wants to merge 1 commit intoopenSUSE:masterfrom
wolfv:win_export_solv_version

Conversation

@wolfv
Copy link
Contributor

@wolfv wolfv commented Apr 25, 2020

Unfortunately I didn't see this the first time around.

I saw that you have a .ver file with all exported symbols but quickly googling didn't tell me if we could use this on Windows as well.

@wolfv
Copy link
Contributor Author

wolfv commented Apr 25, 2020

ok we need to actually install the config.h file otherwise it's not working right.

Would you be OK to move the file to the solv directory as win32_config.h and install it on win systems?

@wolfv wolfv force-pushed the win_export_solv_version branch from d84f014 to a5b7e68 Compare April 25, 2020 16:45
@wolfv wolfv force-pushed the win_export_solv_version branch from a5b7e68 to d67a1de Compare April 25, 2020 16:46
@wolfv
Copy link
Contributor Author

wolfv commented Jul 1, 2020

@mlschroe are there any objections to this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants