Open
Conversation
Conan-Kudo
suggested changes
Aug 7, 2021
Member
Conan-Kudo
left a comment
Conan-Kudo
left a comment
There was a problem hiding this comment.
Note that as this stands, this logic would affect all repo types using libsolv if CONDA was enabled. I'm not sure that's the intent, though I'm honestly not sure this is a bad behavior from a generic perspective, and it might make sense to just unconditionally do it.
Member
|
Yes, the comparison should only be done if the disttype is conda. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.