Skip to content

Add pool_dep_fulfilled_in_map function#592

Merged
mlschroe merged 1 commit intoopenSUSE:masterfrom
kontura:dep_fulfilled
Jul 30, 2025
Merged

Add pool_dep_fulfilled_in_map function#592
mlschroe merged 1 commit intoopenSUSE:masterfrom
kontura:dep_fulfilled

Conversation

@kontura
Copy link
Copy Markdown
Contributor

@kontura kontura commented Jul 1, 2025

This can be used to determine dependency closure on a given set of packages (even with complex dependencies).

It is basically solver_dep_fulfilled(...) but without Solver.

I have created this when looking for a solution to rpm-software-management/dnf-plugins-core#549

This is can be used to determine dependency closure on a given set of
packages (even with complex dependencies).
@mlschroe
Copy link
Copy Markdown
Member

Hi, just as a heads up: I'm fine with adding this but I don't like the name of the function.

@kontura
Copy link
Copy Markdown
Contributor Author

kontura commented Jul 29, 2025

Hi, just as a heads up: I'm fine with adding this but I don't like the name of the function.

Would just pool_dep_fulfilled be better?

@mlschroe
Copy link
Copy Markdown
Member

The _map prefix is fine (though I would drop the _in, because we don't have it in the other functions that have a installedmap argument). I'll merge the pull request now, I'll do the rename later.

@mlschroe mlschroe merged commit b60858c into openSUSE:master Jul 30, 2025
1 check passed
@mlschroe
Copy link
Copy Markdown
Member

I think it's either pool_dep_satisfied_map or pool_dep_fulfilled_map. Any preferences?

@kontura
Copy link
Copy Markdown
Contributor Author

kontura commented Jul 31, 2025

I think it's either pool_dep_satisfied_map or pool_dep_fulfilled_map. Any preferences?

Personally I would prefer fulfilled but only because it is already used in the solver version.

Either way, thank you.

@mlschroe
Copy link
Copy Markdown
Member

Yes, but that's an internal function and not public API so we can rename it any time we like.

@mlschroe
Copy link
Copy Markdown
Member

Looking at other dependency management systems I seems like satisfied seems to be a bit more common. So I tend to go with pool_dep_satisfied_map (or pool_satisfieddep_map because we already have pool_whatmatchesdep and pool_whatcontainsdep).

@kontura
Copy link
Copy Markdown
Contributor Author

kontura commented Jul 31, 2025

I see, pool_satisfieddep_map sounds good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants