chore(deps): refresh lockfile and upgrade ruoqa to 0.2 - #453
Merged
Conversation
ruoqa 0.2 resolves $OPENQA_API_KEY/$OPENQA_API_SECRET as a credential pair ahead of client.conf, switches client.conf discovery to a tiered, non-merging search, and infers the scheme structurally instead of always defaulting to https for a bare host:port. None of mtui's ruoqa call sites change. The new env-var precedence means a developer or CI shell exporting OPENQA_API_KEY/OPENQA_API_SECRET can silently override the credentials a test's client.conf fixture asserts on. Guard the three affected tests with a save/clear/restore of both vars under the existing #[serial(openqa_config_env)] convention, so they stay hermetic regardless of the ambient environment. Update docs/configuration.md and the CHANGELOG's ruoqa migration bullet to describe the tiered discovery, the env-credential pair, and the two other user-visible deltas (path-prefixed openQA instances now sign correctly; --url-openqa host:port now infers http, not https).
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #453 +/- ##
==========================================
- Coverage 96.28% 96.28% -0.01%
==========================================
Files 193 193
Lines 42907 42939 +32
==========================================
+ Hits 41315 41343 +28
- Misses 1592 1596 +4 ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cargo.lock: a plaincargo updatemoving 37 transitive crates, all within existing semver ranges and MSRV-1.96-compatible.Cargo.tomlis untouched by this commit.ruoqa0.1.4 → 0.2. No mtui call sites change; the API surface mtui uses is unchanged upstream.User-visible changes from the ruoqa upgrade
client.confdiscovery is now tiered and non-merging:$OPENQA_CONFIG(when set), else the user config directory ($XDG_CONFIG_HOME/openqa, or~/.config/openqa), else/etc/openqaand/usr/etc/openqa— the first tier that yields any file wins outright, later tiers are not read. A~/.config/openqa/client.confoverride no longer merges with host sections that exist only in/etc/openqa/client.conf.$OPENQA_API_KEY/$OPENQA_API_SECRETare now honoured as a credential pair, taken ahead ofclient.conf.https://host/openqa) is now addressed and signed correctly — previously the prefix was silently dropped, yielding 403/404.--url-openqa localhost:9526now infershttp, nothttps.openqa_instanceURL has the userinfo dropped when resolving the request target, rather than merely redacted for display.docs/src/configuration.mdand theCHANGELOG.md[Unreleased]entry are updated to match.Test hermeticity fix
ruoqa 0.2's new env-credential lookup meant a developer or CI shell exporting
OPENQA_API_KEY/OPENQA_API_SECRETcould silently override the credentials three existing tests assert on viaclient.conffixtures. Added a save/clear/restore guard for both vars, under the existing#[serial(openqa_config_env)]convention, in:crates/mtui-datasources/tests/openqa.rscrates/mtui-core/src/commands/openqa_jobs.rscrates/mtui-datasources/src/openqa/client.rsEach guarded test was observed failing with the vars exported and no guard, then passing with the guard added, with and without the vars set.
Testing
cargo fmt --all --checkcargo clippy --workspace --all-targets -- -D warningsRUSTDOCFLAGS="-D warnings" cargo doc --workspace --no-deps --all-features --document-private-itemscargo test --workspacecargo test -p mtui-mcp -F mcpcargo build --workspace --no-default-features/--all-featurescargo auditmdbook build docscargo run -p mtui-cli -- --help/cargo run -p mtui-mcp --features mcp -- --help