Skip to content

chore(deps): refresh lockfile and upgrade ruoqa to 0.2 - #453

Merged
mimi1vx merged 2 commits into
openSUSE:mainfrom
mimi1vx:upd_ruoqa
Aug 12, 2026
Merged

chore(deps): refresh lockfile and upgrade ruoqa to 0.2#453
mimi1vx merged 2 commits into
openSUSE:mainfrom
mimi1vx:upd_ruoqa

Conversation

@mimi1vx

@mimi1vx mimi1vx commented Aug 12, 2026

Copy link
Copy Markdown
Member

Summary

  • Refresh Cargo.lock: a plain cargo update moving 37 transitive crates, all within existing semver ranges and MSRV-1.96-compatible. Cargo.toml is untouched by this commit.
  • Upgrade ruoqa 0.1.4 → 0.2. No mtui call sites change; the API surface mtui uses is unchanged upstream.

User-visible changes from the ruoqa upgrade

  • client.conf discovery is now tiered and non-merging: $OPENQA_CONFIG (when set), else the user config directory ($XDG_CONFIG_HOME/openqa, or ~/.config/openqa), else /etc/openqa and /usr/etc/openqa — the first tier that yields any file wins outright, later tiers are not read. A ~/.config/openqa/client.conf override no longer merges with host sections that exist only in /etc/openqa/client.conf.
  • $OPENQA_API_KEY/$OPENQA_API_SECRET are now honoured as a credential pair, taken ahead of client.conf.
  • An openQA instance served under a path prefix (https://host/openqa) is now addressed and signed correctly — previously the prefix was silently dropped, yielding 403/404.
  • A bare-authority --url-openqa localhost:9526 now infers http, not https.
  • A credentialed openqa_instance URL has the userinfo dropped when resolving the request target, rather than merely redacted for display.

docs/src/configuration.md and the CHANGELOG.md [Unreleased] entry are updated to match.

Test hermeticity fix

ruoqa 0.2's new env-credential lookup meant a developer or CI shell exporting OPENQA_API_KEY/OPENQA_API_SECRET could silently override the credentials three existing tests assert on via client.conf fixtures. Added a save/clear/restore guard for both vars, under the existing #[serial(openqa_config_env)] convention, in:

  • crates/mtui-datasources/tests/openqa.rs
  • crates/mtui-core/src/commands/openqa_jobs.rs
  • crates/mtui-datasources/src/openqa/client.rs

Each guarded test was observed failing with the vars exported and no guard, then passing with the guard added, with and without the vars set.

Testing

  • cargo fmt --all --check
  • cargo clippy --workspace --all-targets -- -D warnings
  • RUSTDOCFLAGS="-D warnings" cargo doc --workspace --no-deps --all-features --document-private-items
  • cargo test --workspace
  • cargo test -p mtui-mcp -F mcp
  • cargo build --workspace --no-default-features / --all-features
  • cargo audit
  • mdbook build docs
  • cargo run -p mtui-cli -- --help / cargo run -p mtui-mcp --features mcp -- --help

ruoqa 0.2 resolves $OPENQA_API_KEY/$OPENQA_API_SECRET as a credential pair
ahead of client.conf, switches client.conf discovery to a tiered,
non-merging search, and infers the scheme structurally instead of always
defaulting to https for a bare host:port. None of mtui's ruoqa call sites
change.

The new env-var precedence means a developer or CI shell exporting
OPENQA_API_KEY/OPENQA_API_SECRET can silently override the credentials a
test's client.conf fixture asserts on. Guard the three affected tests with
a save/clear/restore of both vars under the existing
#[serial(openqa_config_env)] convention, so they stay hermetic regardless
of the ambient environment.

Update docs/configuration.md and the CHANGELOG's ruoqa migration bullet to
describe the tiered discovery, the env-credential pair, and the two other
user-visible deltas (path-prefixed openQA instances now sign correctly;
--url-openqa host:port now infers http, not https).
@codecov

codecov Bot commented Aug 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.87879% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.28%. Comparing base (ff061cd) to head (022e830).

Files with missing lines Patch % Lines
crates/mtui-core/src/commands/openqa_jobs.rs 90.47% 2 Missing ⚠️
crates/mtui-datasources/src/openqa/client.rs 83.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #453      +/-   ##
==========================================
- Coverage   96.28%   96.28%   -0.01%     
==========================================
  Files         193      193              
  Lines       42907    42939      +32     
==========================================
+ Hits        41315    41343      +28     
- Misses       1592     1596       +4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@mimi1vx
mimi1vx merged commit 99541e6 into openSUSE:main Aug 12, 2026
16 checks passed
@mimi1vx
mimi1vx deleted the upd_ruoqa branch August 12, 2026 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant