Fixes unwanted jumps of the stepper while creating a new Device #704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he info button, while creating a new device.
jona159
approved these changes
Jan 21, 2026
Contributor
jona159
left a comment
jona159
left a comment
There was a problem hiding this comment.
Code changes are approved! Please make sure to only write comments that provide additional information that cannot be derived from the code itself :)
| e.stopPropagation() | ||
| }} | ||
| > | ||
| {/*Treat it as a normal button, rather than treating it as a Submit button*/} |
| e.preventDefault() | ||
| e.stopPropagation() | ||
| }} | ||
| >{/*Covert it to button, so that it is not confused as the Submit button*/} |
Contributor
There was a problem hiding this comment.
The comment is not necessary here as the code change itself is self-explanatory, please remove it
Collaborator
Author
There was a problem hiding this comment.
Alright Thanks:)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Implementation
In the app\components\device\new\new-device-stepper.tsx file I have modified the TooltipTrigger Component in line no:329 to make it a button, other than considering it as a submit button. In the app\components\device\new\general-info.tsx file, I did the same in line no: 124 and made the TooltipTrigger a normal button and prevented it from triggering the unwanted submits. It might seem like the entire file has been modified, but it is because of the formatting issue. Please ignore it..😌
Checklist
devbranchAdditional Information