Add attack taxonomy integration with security check categories#49
Add attack taxonomy integration with security check categories#49thebenignhacker merged 1 commit intomainfrom
Conversation
- Add attackClass field to SecurityFinding interface for taxonomy mapping - Create taxonomy.ts module mapping 100+ HMA check IDs to registry attack classes - Add 5 new check method groups: memory poisoning (MEM-001 to MEM-005), RAG poisoning (RAG-001 to RAG-004), agent identity spoofing (AIM-001 to AIM-003), agent DNA forgery (DNA-001 to DNA-003), and skill memory manipulation (SKILL-MEM-001) - Wire taxonomy enrichment into scanner after all checks complete - Export taxonomy functions from hardening barrel index - Document all new checks in SECURITY_CHECKS.md
There was a problem hiding this comment.
Claude Code Review
VERDICT: APPROVE
SUMMARY: This PR adds attack taxonomy classification to security findings, mapping 147+ security checks to MITRE ATT&CK-inspired categories (prompt injection, data exfiltration, supply chain, etc.). The implementation adds 16 new security checks across 5 new categories (memory poisoning, RAG poisoning, agent identity spoofing, agent DNA forgery, skill memory manipulation) and enriches all findings with taxonomy metadata. The code is purely additive, introduces no security regressions, and follows defensive patterns (safe JSON parsing with try/catch, path traversal prevention via path.relative, bounded directory walking with depth limits).
No CRITICAL or HIGH findings after verification.
FINDINGS:
- [MEDIUM] src/hardening/scanner.ts:6182 — Directory walk helper uses maxDepth=10 default which could traverse deeply nested malicious directory structures. However, this is mitigated by (a) skipDirs filtering common exploit targets and (b) caller-side slicing of results (.slice(0, 50) at lines 6321, 6521, 6563), so the actual risk is bounded. Not blocking.
Reviewed 5 files changed (41578 bytes)
Summary
Test plan
npm run buildcompiles without errorsnpm testpasses all 915+ testsnpx hackmyagent secure --ciincludes taxonomy class in findings