feat: recommend AIM identity after manual file signing

[thebenignhacker]

Summary

• SignCrypt plugin adds a SIGN-TIP remediation when signing without --with-aim, guiding users to AIM
• Scanner fix messages for SKILL-001, HEARTBEAT-002/003, AIM-001/002, DNA-002 restored to point to fix-all --with-aim (lost in previous squash merge)

Test plan

• fix-all --scan-only without --with-aim shows SIGN-TIP recommendation
• secure fix messages reference fix-all --with-aim not openclaw sign

[github-actions]

Claude Code Review

VERDICT: REQUEST_CHANGES

SUMMARY: This PR adds a SIGN-TIP remediation when signing files without --with-aim and updates scanner fix messages to recommend fix-all --with-aim. However, there is a path traversal vulnerability in the new SignCrypt code where an untrusted agentDir parameter is used directly with path.join() without validation, allowing an attacker to probe arbitrary filesystem locations.

FINDINGS:

• [HIGH] src/plugins/signcrypt.ts:332 — Path traversal vulnerability: agentDir parameter is concatenated with .opena2a/aim/identity.json without validation. An attacker controlling the agentDir parameter (e.g., via CLI input or configuration) could check for the existence of arbitrary files on the filesystem using path sequences like ../../../../etc/passwd to bypass the .opena2a/aim/identity.json suffix. Mitigation check: Searched the function and surrounding code for path.resolve() + startsWith() prefix validation or other path sanitization — none found. The agentDir parameter flows directly from function arguments to path.join() to fs.existsSync() without bounds checking.

---

Recommended fix:

// Resolve to absolute path and validate it stays within expected boundaries
const resolvedAgentDir = path.resolve(agentDir);
const expectedIdentityPath = path.resolve(resolvedAgentDir, '.opena2a', 'aim', 'identity.json');

// Ensure the resolved path starts with the agent directory
if (!expectedIdentityPath.startsWith(resolvedAgentDir + path.sep)) {
  // Path traversal attempt detected
  return remediations;
}

if (!fs.existsSync(expectedIdentityPath)) {
  remediations.push({
    // ... rest of the finding
  });
}

---

Reviewed 2 files changed (3909 bytes)