fix(scan): use the registered scan ID in agent prompts - #296
Open
dipeshbabu wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
@mldangelo could you review this pr? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #290
Fixes #292
Summary
Root cause
The prompt was created before scan registration and referred to
$CODEX_SECURITY_SCAN_ID. That placeholder is not expanded inside structured MCP arguments or agent-authored artifacts, so deep scans could send an invalid literal ID and standard scans could write a different UUID that finalization rejected.Impact
Deep scans now call
start_codex_security_deep_scanwith the registered UUID, and all scan modes instruct the agent to use that same UUID in canonical artifacts.Validation
pnpm dlx bun test --timeout 30000 ./tests-ts/api.test.ts --test-name-pattern "uses the registered scan ID in standard and deep prompts|encodes valid Unicode Git refs as data before sending the scan prompt|provides only reviewed false positives"— 3 passedpnpm exec tsc --noEmitpnpm exec prettier --check src/api.ts tests-ts/api.test.tsgit diff --checkThe complete API test file reached 80 passing tests; its remaining nine tests are blocked in this local Windows environment by the existing credential-home ancestor ACL check.