test(cli): cover interactive and headless scan progress - #318
test(cli): cover interactive and headless scan progress#318mldangelo-oai wants to merge 1 commit into
Conversation
|
@codex review |
|
Closing this draft because all five imported progress scenarios are already covered in tests-ts/cli.test.ts. Keeping the sync stack free of duplicate coverage. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2f911db1e3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| describe("CLI scan progress", () => { | ||
| test("uses plain scan progress in headless, CI, and noninteractive terminals", async () => { |
There was a problem hiding this comment.
Remove the already-covered progress suite
Every test in this suite duplicates an existing test byte-for-byte in tests-ts/cli.test.ts (at lines 1503, 1559, 1590, 4273, and 4311). Because bun test ./tests-ts discovers both files, the five scenarios now execute twice without adding coverage, increasing suite time and leaving two copies that can diverge when progress behavior changes.
Useful? React with 👍 / 👎.
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
Summary
Verification
pnpm dlx bun@1.3.13 test --timeout 30000 ./tests-ts/cli-progress.test.ts(5 passed; 77 assertions)pnpm run typespnpm exec prettier --check tests-ts/cli-progress.test.ts