Skip to content

test(cli): cover interactive and headless scan progress - #318

Closed
mldangelo-oai wants to merge 1 commit into
mainfrom
mdangelo/codex/public-cli-progress-coverage-20260808
Closed

test(cli): cover interactive and headless scan progress#318
mldangelo-oai wants to merge 1 commit into
mainfrom
mdangelo/codex/public-cli-progress-coverage-20260808

Conversation

@mldangelo-oai

Copy link
Copy Markdown
Collaborator

Summary

  • Port the monorepo's focused CLI scan-progress regression coverage into the public SDK.
  • Verify headless and CI progress, interactive terminal dashboards, live token/cost updates, and deduplicated file progress.
  • Match the public CLI's real ANSI escape sequences when asserting alternate-screen transitions.

Verification

  • pnpm dlx bun@1.3.13 test --timeout 30000 ./tests-ts/cli-progress.test.ts (5 passed; 77 assertions)
  • pnpm run types
  • pnpm exec prettier --check tests-ts/cli-progress.test.ts

@github-actions github-actions Bot added the skip-release-notes Omit internal changes from generated release notes label Aug 8, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@mldangelo-oai

Copy link
Copy Markdown
Collaborator Author

Closing this draft because all five imported progress scenarios are already covered in tests-ts/cli.test.ts. Keeping the sync stack free of duplicate coverage.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2f911db1e3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +6 to +7
describe("CLI scan progress", () => {
test("uses plain scan progress in headless, CI, and noninteractive terminals", async () => {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3 Badge Remove the already-covered progress suite

Every test in this suite duplicates an existing test byte-for-byte in tests-ts/cli.test.ts (at lines 1503, 1559, 1590, 4273, and 4311). Because bun test ./tests-ts discovers both files, the five scenarios now execute twice without adding coverage, increasing suite time and leaving two copies that can diverge when progress behavior changes.

Useful? React with 👍 / 👎.

@chatgpt-codex-connector

Copy link
Copy Markdown

Security review completed. No security issues were found in this pull request.

Reviewed commit: 2f911db1e3

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-release-notes Omit internal changes from generated release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant