fix(zod): sanitize extracted definition refs#1903
Merged
HAYDEN-OAI merged 4 commits intoJun 24, 2026
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6ad9563f79
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
HAYDEN-OAI
approved these changes
Jun 24, 2026
Contributor
|
@FU-max-boop thanks for tracking this down and for sticking with the collision-safe ref handling. appreciate your patience while we brought the branch current and worked through the recursive-schema edge case. merging now! 💚 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_when zod v3 schemas extract reused definitions to root refs$refvalues anddefinitionskeys aligned after normalizationWhy
zodResponseFormatcan currently produce$refvalues such as#/definitions/example-scope_properties_group_properties_Thing With Spaces. Those literal spaces can be rejected by the API and make the generated schema harder to consume.Fixes #1679.
Testing
npx -y yarn@1.22.22 test tests/helpers/zod.test.ts --runInBandnpx -y yarn@1.22.22 prettier --check src/_vendor/zod-to-json-schema/parseDef.ts tests/helpers/zod.test.tsnpx -y yarn@1.22.22 eslint src/_vendor/zod-to-json-schema/parseDef.ts tests/helpers/zod.test.tsnpx -y yarn@1.22.22 buildgit diff --check