fix(runner): normalize missing tool call IDs#1958
Merged
Merged
Conversation
Some providers do not populate the `tool_call.id` field when returning tool calls, or may set it to an empty string. When the SDK's `AbstractChatCompletionRunner._runTools()` method constructs tool result messages to send back to the API, it uses this empty or missing `tool_call_id`, which causes the API to reject the request with a 400 status code. Signed-off-by: anish <anishesg@users.noreply.github.com>
# Conflicts: # src/lib/AbstractChatCompletionRunner.ts
Co-authored-by: anish <anishesg@users.noreply.github.com>
apcha-oai
approved these changes
Jun 25, 2026
|
Thank You |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
GitHub rejected the maintainer push to the organization-owned fork even though the PR reports maintainer edits as enabled. This integration branch therefore merges the original PR commit and builds the corrected implementation on top of it rather than recreating the contribution separately.
Validation
pnpm exec jest tests/lib/ChatCompletionRunFunctions.test.ts --runInBandpnpm exec tsc --noEmitpnpm buildCloses #1528