fix(assistants): place array delta entries by index instead of appending#1963
Open
spokodev wants to merge 1 commit into
Open
fix(assistants): place array delta entries by index instead of appending#1963spokodev wants to merge 1 commit into
spokodev wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When accumulating streamed array deltas,
AssistantStream.accumulateDeltareads and writes entries by their
indexfield. The branch that handles anot-yet-seen entry appended it with
pushinstead of assigning it ataccValue[index]. These only agree when the index equals the current arraylength, so any non-contiguous or out-of-order
indexlands the entry at thewrong position.
The consequence is data corruption: because the entry is not at
accValue[index],a later fragment for the same index finds an empty slot and appends again. The
same tool call (or content block) ends up as two separate array entries with
split, invalid JSON arguments in the accumulated snapshot.
This assigns the entry at its
index, matching the sibling branch and thePython SDK, which uses
insert(index, entry)for the same case. The existingcontiguous path is unchanged.
Added a unit test that seeds an entry at index 0, then streams two fragments
for index 2. Before the fix the array holds two index-2 entries with split
arguments; after the fix it holds one merged entry.