Handle keepalive events in Responses streams#1965
Open
koriyoshi2041 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Responses streaming can receive
keepaliveSSE events on long-running requests. They do not carry Response state, but the accumulator currently falls through to the exhaustive error path and ends the stream. Fixes #1964.Fix
Treat
keepaliveas a no-op accumulator event, alongside other stream events that do not map onto the Response snapshot. Unknown event types still go through the existing error path.Test
pnpm test tests/lib/ResponseAccumulator.test.tspnpm exec prettier --check src/lib/responses/ResponseAccumulator.ts tests/lib/ResponseAccumulator.test.tspnpm buildgit diff --checkRisk
Low. This only ignores the explicit
keepaliveevent; it does not change handling for normal response deltas or undocumented unknown event types.