export runner options type#1968
Open
sarptandoven wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
RunnerOptionsfrom the public package and chat completions resource surfacesOpenAInamespace for parity with other chat completion typeschange
openainow supportsimport type { RunnerOptions } from "openai"openai/resources/chat/completionsnow supportsimport type { RunnerOptions } ...OpenAI.RunnerOptionsis available in the root namespacewhy
runToolsalready acceptsRunnerOptionsinternally, but users could not name the options type from public exports when configuringmaxChatCompletions.fixes #593
tests
pnpm exec tsc --noEmit --pretty falsepnpm exec jest tests/runner-options-exports.test.ts --runInBandpnpm lint