fix(types): type annotation field as Annotation instead of object#3430
Open
Shriniwas410 wants to merge 1 commit into
Open
fix(types): type annotation field as Annotation instead of object#3430Shriniwas410 wants to merge 1 commit into
Shriniwas410 wants to merge 1 commit into
Conversation
… Annotation union
nomiveritas
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ResponseOutputTextAnnotationAddedEvent.annotationis typed asobject, forcing consumers to usetyping.castor suppress type errors to access typed fields liketitle,url,file_id.response_output_text.pyalready defines the correct discriminated unionAnnotation = Annotated[Union[AnnotationFileCitation, AnnotationURLCitation, AnnotationContainerFileCitation, AnnotationFilePath], PropertyInfo(discriminator="type")].This PR imports and uses that type, removing the need for workarounds.
Fixes #3419