Skip to content

Use path name for service account updates#452

Open
fallintoplace wants to merge 1 commit into
openai:mainfrom
fallintoplace:fix/service-account-update-path
Open

Use path name for service account updates#452
fallintoplace wants to merge 1 commit into
openai:mainfrom
fallintoplace:fix/service-account-update-path

Conversation

@fallintoplace

Copy link
Copy Markdown

Summary

  • make service account updates look up the resource by the URL path name
  • reject requests where the JSON body name points at a different service account
  • add controller regressions for mismatched and matching update requests

Testing

  • go test ./internal/controller
  • go test -run '^$' ./...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant