[codex] Preserve running VMs across controller restarts#454
Open
fkorotkov-oai wants to merge 1 commit into
Open
[codex] Preserve running VMs across controller restarts#454fkorotkov-oai wants to merge 1 commit into
fkorotkov-oai wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
workerOfflineTimeoutafter scheduler startupRoot cause
Worker heartbeats are persisted in the controller database. After a controller outage longer than
workerOfflineTimeout, the restarted scheduler could observe the stale heartbeat and mark assigned VMs as failed before their worker had time to reconnect, even though those VMs continued running throughout the outage.Impact
Workers now receive one configured offline timeout after scheduler startup to reconnect before stale heartbeats can fail their VMs. Normal steady-state worker failure detection and offline-worker scheduling exclusion remain unchanged. A genuinely unavailable worker can take up to one additional timeout after a controller restart to have its VMs marked failed.
Validation
go test ./internal/controller/... -count=1go test ./internal/tests -run '^TestControllerRestart(DoesNotFailRunningVMs|HelperProcess)$' -count=1golangci-lint run ./internal/controller/scheduler ./internal/tests