[WIP] Development version (PIAF)

[pradal]

No description provided.

[pradal]

Please, name your modules (python.py files) with only lower cases.
And also functions.

Use ratp2vtk rather than RATP2VTK
And do not use pyratp into module names.
Because the modules are part of the openalea.ratp package

[pradal]

@cyrilbz : Do you need to rename the package openalea.ratp into openalea.pyratp?

[cyrilbz]

@pradal No, no need to rename the package I think!
I updated my branch with the new 3D voxel viewer (based on PyVista library), see attached screenshot.

I will start now satisfying your request about upper/lower cases, and will let you know when I am done.

[cyrilbz]

@pradal I resolved the upper case issue for module names. Changing the file name RATP2VTK.py into lower case requires changing meson.build in src/openalea/ratp, and it's not the only file name that contains upper cases... let me know if you want me to update all of them!

[pradal]

@cyrilbz Can we merge this version to release it?
We plan to have a first release before Xmas.

[cyrilbz]

Yes absolutely! The 3D viewer relies on the pyvista library to work. We can keep it optional. In any case, each time the viewer is called if pyvista is not installed it will raise an error:

try:
    import pyvista as pv
except ImportError:
    raise ImportError(
    "PyVista is not installed. "
    "Please install it with: pip install pyvista"
    )

There is only one tutorial relying on Vegestar data. Could you give me a notebook with the creation of a virtual 3D plant that I could import into PyRATP using some of the tools in src/openalae/src/RatpScene.py so I can create a new tutorial? This would also make a starting point for the comparison of RATP with other software based on virtual plants.

Best regards,

Cyril

[pradal]

Yes. I will send you a 3D scene.
Do you prefer a MTG with geometry or just a mesh?

For pyvista, we can add it as an optionoal dependency.

[cyrilbz]

Yes. I will send you a 3D scene. Do you prefer a MTG with geometry or just a mesh?

I think having a full MTG is better as an example of interoperability with the rest of openalea. I was more thinking of a notebook WITH the creation of such virtual plant (so, calling other libs of openalea). Then I have no idea how the RatpScene.py actually works. It takes as input a PlantGL scene.

[cyrilbz]

Lot's of files are empty. Can we remove them?

Yes, of course!

[baugetfa]

I did 2 commits, in particular I added a For developers Linux (python change only) because it is better than running pip install at each change on python files

[pradal]

Thanks for the commits!
@cyrilbz We have now merge the branch. So you can move to the master.
If you have some modifications, create a new branch.
I have added the visualea workflows.
They are not completly functional, but there are 3D scenes.