Batfish agent#33
Open
Laur04 wants to merge 2 commits intoopenalto:mainfrom
Open
Conversation
fno2010
reviewed
Jan 11, 2023
Member
fno2010
left a comment
fno2010
left a comment
There was a problem hiding this comment.
It looks like a good starting point for the CP-based agent.
|
|
||
| self.bf = Session(host="localhost") | ||
|
|
||
| self.bf.init_snapshot('/data/live', name='live', overwrite=True) |
Member
There was a problem hiding this comment.
Is /data/live a hardcoded path? Should it be configured by the agent JSON file?
| "namespace": "default", | ||
| "agent_class": "alto.agent.batfish.BatfishAgent", | ||
| "refresh_interval": 300 | ||
| } No newline at end of file |
Member
There was a problem hiding this comment.
I wonder why the agent JSON file doesn't include any config of network control plane snapshot data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
docker-composefile had to be modified from the typical agent format because batfish itself has to run inside a docker container and the agent containers can't talk individually to other containers. I reconfigured it so that the batfish agent runs inside the same container as the batfish server.