Enable sorting by new fields from entitycore, address circuit sorting#1525
Merged
Enable sorting by new fields from entitycore, address circuit sorting#1525
Conversation
Preview Deployment
|
Collaborator
Author
|
FYI, @jdcourcol |
Contributor
|
cool I will give it a try |
Contributor
|
wow, it is very slow now. |
Collaborator
Author
|
@jdcourcol do you think we should we asses ways to improve performance and address the issue before merging this or it's "fine" as is? |
Contributor
|
we definitely have a performance issue. probably, @bilalesi PR related to facets should improve the situation. Also, I notice we have to add additional sorting fields to entitycore, I will follow up on this. |
Contributor
Contributor
fd3e4ce to
f8b2fbf
Compare
Collaborator
Author
|
@jdcourcol thank you, sorting for both: ion channel recordings and neuron density should be addressed now, I've enabled missing columns. |
Collaborator
Author
f8b2fbf to
83d92ec
Compare
4b2543d to
41b273f
Compare
bilalesi
approved these changes
Apr 22, 2026
Collaborator
Author
|
Thank you Bilal |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Changes
New sortable fields (
entity-configuration/definitions/fields-defs/)common.tsx:
BrainRegion— extend to Circuit subtypes, IonChannelModel, IonChannelRecording, EMCellMesh, Emodel, ComputationallySynthesizedCellMorphologySpeciesName— extend to CellMorphology, UniversalCellMorphology, ComputationallySynthesizedCellMorphology, IonChannelModel, IonChannelRecording, Circuit, MEModelWithSynapsesCreatedBy— extend to Circuit subtypes, EMCellMesh, EModel, IonChannelModel, Simulation, SimulationCampaign subtypesContributions/InstitutionalContributions— fix broken order config (contribution__order_by/pref_label→order_by/contribution__pref_label), enable sortingIonChannel— fix order value (ion_channel→ion_channel__name)model.tsx:
CircuitNumberNeurons,CircuitNumberSynapses,CircuitNumberConnections,CircuitScale,CircuitBuildCategoryTemperatureCelsius,IsLjpCorrected,IsStochastic,IsTemperatureDependent(IonChannelModel)NumberConnectionssorting to MEModelWithSynapsesArtifactPublishedIn,ArtifactExperimentDate(Circuit)experimental.tsx:
MeshType(EMCellMesh)MTypesorting to MemodelETypeon IonChannelRecording, ExperimentalNeuronDensity, and MemodelIonChannel,Temperature,CellLine(IonChannelRecording)NumberOfMeasurements,MeanSTD,Sem(ExperimentalBoutonDensity)PreSynapticBrainRegion,PostSynapticBrainRegion,PreSynapticCellType,PostSynapticCellType(ExperimentalSynapsesPerConnection)experiment.tsx:
CircuitNumberNeurons,CircuitNumberSynapses,CircuitNumberConnectionsdefinitions (now in model.tsx)Disable sorting in circuit hierarchy view
use-data-table-columns.tsx— gateisSortableonsetSortStatebeing provided; fix stale sort-state closure via ref; simplifysortDirectionsto['ascend', 'descend']circuit/index.tsx— passundefinedforsortState/setSortStatein hierarchy viewTest plan
order_byparam in network requests