Update asset labels for cell meshes#553
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
I thought this: was for morphologies, not for em_cell_mesh. |
|
and for this: |
I understood from the linked tickets that the mesh itself can be represented as a single .obj or .glb, and that there can be a directory with many files in .glb format, representing small blocks.
Agreed, but where should it go? The description in the asset label table is meant to be a short description, while for detailed specifications there should be a separate document (like for sonata specs, for example). |
|
There are
|
|
Considering the comment https://github.com/openbraininstitute/Ultraliser/issues/211#issuecomment-4066661627 and previous clarifications with @marwan-abdellah and @jdcourcol:
@marwan-abdellah and @jdcourcol can you confirm the points above, and the changes in this PR? |
|
There is a 3rd bullet from my comment:
|
mgeplf
left a comment
There was a problem hiding this comment.
the entitycore side looks fine to me
Clarified and updated the PR with a new asset label for the cell morphology:
Use case:
The process to generate the mesh is the opposite of skeletonization. |
Implement:
and remove custom .h5 format for cell_surface_mesh, since not used and replaced by .glb.
In both staging and production there are only:
EDIT based on the comments below, these asset labels have been added: