fix(cli): mention all-pages flags in next-page hint#810
Conversation
|
Codex review: needs maintainer review before merge. Reviewed June 15, 2026, 1:30 AM ET / 05:30 UTC. Summary Reproducibility: yes. Current main’s shared helper deterministically emits only the page-token hint, while representative commands already expose full-page flags, so no live Google API call is needed to verify the wording gap. Review metrics: 2 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Next step before merge
Security Review detailsBest possible solution: Land the focused wording PR after maintainer review and exact-head checks, preserving the old helper for commands that only support page-token navigation. Do we have a high-confidence way to reproduce the issue? Yes. Current main’s shared helper deterministically emits only the page-token hint, while representative commands already expose full-page flags, so no live Google API call is needed to verify the wording gap. Is this the best way to solve the issue? Yes. Adding a small helper that accepts exact supported flag text and using it only on commands with full-pagination flags is narrower than changing pagination behavior or adding flags. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 23b847ca53cf. Label changesLabel justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
🦞👀 Source: I left the PR open for the remaining gate instead of bypassing it. Automerge progress:
|
|
@clawsweeper stop |
|
🦞✅ I added |
Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com>
9df015c to
30fa959
Compare
Fixes #808
Summary
--page <token>docs/refactor/output.mdso the documented helper contract matches the new outputNotes
This is a discoverability-only wording change. It keeps stdout parseable, keeps the hint on stderr, and does not add flags or change pagination behavior.
Source issue credit: reported by @privatenumber in #808.
Validation
go test -vet=off ./internal/cmdmake testClawSweeper 🐠 replacement reef notes:
fish notes: reasoning high; reviewed against 9df015c.