fix(docs): expose heading IDs in enumerator JSON#820
Conversation
|
Codex review: passed. Reviewed June 15, 2026, 11:27 AM ET / 15:27 UTC. Summary Reproducibility: yes. Source inspection shows current main omits Review metrics: none identified. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Next step before merge
Security Review detailsBest possible solution: Land the narrow JSON-only headingId exposure with regression coverage if maintainers accept the expanded output contract, leaving named ranges on the existing named-range command surface. Do we have a high-confidence way to reproduce the issue? Yes. Source inspection shows current main omits Is this the best way to solve the issue? Yes. Carrying the existing Docs API field through the enumerator model into JSON is the narrowest maintainable fix, and preserving TSV/plain output avoids changing the stable text format. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 02c893f2e702. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
Landed as Maintainer fixups added the changelog/docs entry and semantic JSON contract assertions for the literal |
Fixes #819
Summary
headingIdtodocs headings list --jsonheading objectsheadingIdtodocs paragraphs list --jsonparagraph objectsdocs named-range listfor named range anchorsNotes
bookmarkId/headingIdmetadata in paragraph runs.Validation
headingIdautoreview --mode branch --base origin/main --parallel-tests 'make ci': clean, no actionable findingsmake ci: pass