Add libgit2 dependency for desktop client#6
Open
msexxeta wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Follow-up for https://github.com/orgs/opencloud-eu/discussions/2891.
The desktop client change adds libgit2-based text conflict automerge: opencloud-eu/desktop#934. This PR makes the Craft blueprint resolve and package libgit2 for
opencloud/opencloud-desktop.Changes
libs/libgit2as a runtime dependency of the OpenCloud Desktop Craft blueprint.Verification
opencloud/opencloud-desktopCraft build tree and the blueprint__pycache__so Craft had to re-evaluate the changed blueprint..craft.iniand workflow override using-i --install-deps --compile --install.LibGit2from the Craft prefix.450/450), install succeeded, and qmerge succeeded.OpenCloudLibSync.dlldepends ongit2.dllwithdumpbin /dependents.