Skip to content

Add option to output json format reports#768

Open
LucoDevro wants to merge 2 commits into
opencobra:developfrom
LucoDevro:develop
Open

Add option to output json format reports#768
LucoDevro wants to merge 2 commits into
opencobra:developfrom
LucoDevro:develop

Conversation

@LucoDevro

Copy link
Copy Markdown
  • Does not fix an open issue: it adds functionality
  • description of feature/fix

Json files are easier to parse for automated high-throughput applications. Since this output option was silently supported in the API, I exposed it via a Boolean flag.

  • tests added/passed

All tests passed (make qa).

Json files are easier to parse for automated high-throughput applications. Since this output option was silently supported in the API, I exposed it via a Boolean flag.
@Midnighter

Copy link
Copy Markdown
Member

Hi @LucoDevro,

Thank you for the contribution. I agree that this is very useful. It's been on my mind for years now, but I only get to work on memote in my spare time. I've held off on making this available so far, because I thought it would not be that useful without also offering a solution to load JSON files and creating a report from that.

Do you have a use just for this part already?

@LucoDevro

Copy link
Copy Markdown
Author

I'm setting up a high-throughput curation workflow and memote nicely puts together some tests. At some point, I needed to get the identifiers of the flagged reactions of course, and those are easier to get from a json than from an html.

@Midnighter

Copy link
Copy Markdown
Member

In that case, please also take a look at https://github.com/opencobra/jeweler which is a nextflow pipeline for running memote on many samples.

@LucoDevro

Copy link
Copy Markdown
Author

Thanks for the suggestion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants