[Opus 4.6 PR-1] Insecure Randomness in Token/Secret Generation (base.go)#121
Open
arunkoshy wants to merge 1 commit into
Open
[Opus 4.6 PR-1] Insecure Randomness in Token/Secret Generation (base.go)#121arunkoshy wants to merge 1 commit into
arunkoshy wants to merge 1 commit into
Conversation
Issue: rand.Seed(time.Now().UnixNano()) + math/rand is cryptographically insecure. Auth tokens, secret keys, and account validation links are all generated with predictable PRNG. An attacker who can approximate server start time can reproduce tokens. Fix: Replace math/rand with crypto/rand for all security-sensitive generation (GenerateAuthToken, GenerateAccountACKLink, randAlpha, randAlphaSlashPlus). Race condition: randInit is read/written without synchronization across goroutines — itself a data race. Test: Unit tests proving output entropy (no repeated values across 10k calls), and that crypto/rand is the source. Signed-off-by: Arun Koshy <arunkoshy@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: rand.Seed(time.Now().UnixNano()) + math/rand is cryptographically insecure. Auth tokens, secret keys, and account validation links are all generated with predictable PRNG. An attacker who can approximate server start time can reproduce tokens. Fix: Replace math/rand with crypto/rand for all security-sensitive generation (GenerateAuthToken, GenerateAccountACKLink, randAlpha, randAlphaSlashPlus).
Race condition: randInit is read/written without synchronization across goroutines — itself a data race.
Test: Unit tests proving output entropy (no repeated values across 10k calls), and that crypto/rand is the source.