Add artifact manager and chassis manager.#318
Open
Chounoki wants to merge 7 commits into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces in-memory implementations for artifact and chassis management, along with their associated configuration protobufs and build configurations. The review feedback highlights several areas for improvement, including the removal of unused types in the ownership voucher package, the addition of nil checks to prevent runtime panics and improve error reporting in the managers, and the correction of a typo in the 'ownership_certificate' field name across the proto and Go source files.
Chounoki
force-pushed
the
pr0
branch
5 times, most recently
from
cdee004 to
8c3aad6
Compare
Chounoki
changed the title
Chounoki
force-pushed
the
pr0
branch
2 times, most recently
from
915d679 to
43ecc0c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.