ICMP Extensions YANG Model (RFC 5837)#4593
Closed
gcodeflux wants to merge 263 commits into
Closed
Conversation
* removing deviation * Resolving conflicts * resolving conflicts --------- Co-authored-by: Ram <rmachat@google.com>
…st.go (#4254) Update package name for feature/bgp/tests/local_bgp_test/local_bgp_test.go
* Create README for Static GUE Encapsulation --------- Co-authored-by: Darren Loher <dloher@google.com>
metadata.proto file udpated for 'static_protocol_name'.
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
…ues correctly on the NTE ports (#4073)
* Update zr_input_output_power_test.go * Update zr_tunable_parameters_test.go * Update zr_logical_channels_test.go * Update zr_cd_test.go * Update zr_firmware_version_test.go * Update zr_pm_test.go * Update zr_laser_bias_current_test.go
* Remove all feature.textproto files and references.
* (D) **/feature.textproto
- remove feature.textproto since these files are no longer being
maintained. the README.md for each test case defines the paths
that are expected to be supported.
* (M) proto/feature.proto
- remove all fields other than the feature profile ID that is
used elsewhere.
* (D) tools/validate_paths.go
- remove util that checks contents of feature.textproto.
* Remove workflow that checks paths from CI.
---------
Co-authored-by: Nikki Kumar <nikkikumar@google.com>
* Update static_route_bgp_redistribution_test.go * Update metadata.textproto --------- Co-authored-by: Nikki Kumar <nikkikumar@google.com>
…oad (#4147) * add encap anpf ipv4 test case * Update mpls_gre_ipv4_encap_test.go * Update mpls_gre_ipv4_encap_test.go * Update otgconfighelpers.go * Update otgflowhelpers.go * Update otgvalidationhelpers.go * add .pb file * Update mpls_gre_ipv4_encap_test.go * Update mpls_gre_ipv4_encap_test.go . * add fmt files * fmt files * go fmt * github workflow fixes * Update otgconfighelpers.go * Update otgflowhelpers.go * Update mpls_gre_ipv4_encap_test.go * Update policyforwarding.go * Update policyforwarding.go * Update metadata.proto * Update metadata.proto * Update deviations.go * Update policyforwarding.go * add static nexthop file * Update mpls_gre_ipv4_encap_test.go * add .pb file * Update policyforwarding.go * Update staticnexthop.go * Update interface.go * Update policyforwarding.go * Update staticnexthop.go * Update mpls_gre_ipv4_encap_test.go * fmt metadata.pb.go * fmt go files * add .pb.go file * Update policyforwarding.go * go fmt * Update staticnexthop.go * Update staticnexthop.go * go fmt * Update mpls_gre_ipv4_encap_test.go * Update mpls_gre_ipv4_encap_test.go * Update policyforwarding.go * Update atedut_4links_10lr.testbed * Update metadata.proto * Update metadata.textproto * add 100g links testbed file * delete 10 g lr testbed file * Update metadata.proto * Update metadata.proto * Update metadata.textproto * remove file * add pb .go file * add metadata.pb.go --------- Co-authored-by: Nisha Sadhasivam <nsadhasivam@google.com> Co-authored-by: Pramod Maurya <pramodmaurya@google.com>
* Update suppress_ipv6_nd_ra_test.go * Update suppress_ipv6_nd_ra_test.go * gofmt --------- Co-authored-by: Ram <rmachat@google.com>
* TE-9.2 deviation UseOldOCPathStaticLspNh with issues/404301960 * Delete del/plt-1.1/logs mistakenly added troubleshooting logs * Update deviations.go mistakenly deleted old deviations
* Update README.md This FNT was already written and merged. Just added the ocpath s for telemetry. * Update README.md * Update README.md * Update README.md Updated the OC paths and the formats * Update README.md Updated the OC paths for telemetry. The actual FNT was approved and automated. Just the 2*ocpaths for telemetry was added. * Update README.md Updated the OC paths with ":" at the end * Update README.md --------- Co-authored-by: Rohit Rattan <rohitrattan@google.com>
…fig sequence (#4215) * pull#4007 changes impact the config dependency. Corrected to have otn->eth config sequence for Juniper device * Removing else condition
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
…3695) * updating prefix length * updating prefx length * updating prefx length * adding deviation
* Added deviation for config leaf requires create * Added deviation for config leaf requires create * Added deviation for config leaf requires create * Conflicts resolved * Fixed sleep timers * Fixed timers * fixed formatting * Revert "fixed formatting" This reverts commit db23bf1. * fixed syntax error * fixed formatting issues --------- Co-authored-by: AmrNJ <155722765+AmrNJ@users.noreply.github.com> Co-authored-by: Nikki Kumar <nikkikumar@google.com>
…, decap TTL and DSCP behavior test (#4178) * Static GUE decapsulation README * Updated the readme with suggested changes * Apply suggestions from code review Co-authored-by: sachendras <44847441+sachendras@users.noreply.github.com> * Added pointer to ECMP hashing test * Aligning the readme with GUEv1 rfc * Changing the folder for this Readme * Updating the folder name * Fixing typos * Updating the FNT title * updated folder names * Update feature/policy_forwarding/otg_tests/ip_guev1_static_decap_subnet_range/README.md Co-authored-by: Darren Loher <dloher@google.com> * Incorporating the suggestions from review feedback and moving it to different folder * Update feature/policy_forwarding/decapsulation/otg_tests/ip_guev1_static_decap_subnet_range/README.md Co-authored-by: Rob Shakir <robjs@google.com> * Update feature/policy_forwarding/decapsulation/otg_tests/ip_guev1_static_decap_subnet_range/README.md Co-authored-by: Rob Shakir <robjs@google.com> * Update feature/policy_forwarding/decapsulation/otg_tests/ip_guev1_static_decap_subnet_range/README.md Co-authored-by: Rob Shakir <robjs@google.com> * Update feature/policy_forwarding/decapsulation/otg_tests/ip_guev1_static_decap_subnet_range/README.md Co-authored-by: Rob Shakir <robjs@google.com> * Update feature/policy_forwarding/decapsulation/otg_tests/ip_guev1_static_decap_subnet_range/README.md Co-authored-by: Rob Shakir <robjs@google.com> * Update feature/policy_forwarding/decapsulation/otg_tests/ip_guev1_static_decap_subnet_range/README.md Co-authored-by: Rob Shakir <robjs@google.com> * Updating the FNT with review suggestions * Update feature/policy_forwarding/decapsulation/otg_tests/ip_guev1_static_decap_subnet_range/README.md Co-authored-by: Rob Shakir <robjs@google.com> * Update feature/policy_forwarding/decapsulation/otg_tests/ip_guev1_static_decap_subnet_range/README.md Co-authored-by: Rob Shakir <robjs@google.com> * updating the definition for IMIX frame sizes * Review feedback adjustments * Update README.md --------- Co-authored-by: sachendras <44847441+sachendras@users.noreply.github.com> Co-authored-by: Darren Loher <dloher@google.com> Co-authored-by: Rob Shakir <robjs@google.com>
* gnmi-1.13 - Format required OC paths properly
Remove ` ` in subtest names -> `gNPSI-1.X` vs `gNPSI 1.X`. Co-authored-by: Rob Shakir <robjs@google.com>
* upated scripts with deviation for setmed action * Update route_installation_test.go * updated deviation --------- Co-authored-by: lvaish05 <168406079+lvaish05@users.noreply.github.com> Co-authored-by: Nikki Kumar <nikkikumar@google.com>
…4536) * Cache the components fetched from the device to improve test latency
Co-authored-by: Swetha-haridasula <haridasula@google.com>
* Add README for BGP scale test (RT-1.65). * Add README for BGP scale test (RT-1.65). * Add README for BGP scale test (RT-1.65). * address comments
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
* fixing Dial SSH for all 3 formats of SSH Dial * fixing tests * fixing static error * fixing static analysis error for ssh_public_key_authentication * fixed static analysis error * fixing the build error
…unnel (#4217) * Add test PF-1.2: Policy-based traffic GRE Encapsulation to IPv4 GRE tunnel
* Fixing script issues * Fixing script issues * adding waitforarp * fixing space issue * incorporating comments
* Changing cfg plugings to have option for batch and non batch gnmi.update * Changing metadata.textproto path for github * Update feature/gnmi/tests/gnimi_ni_test/metadata.textproto Changing plan_id Co-authored-by: Darren Loher <dloher@google.com> * Changing function naming from "Configure*" to "New*" * Adding struct for NetworkInstance * Changing sytax using NetworkInstanceParams --------- Co-authored-by: Darren Loher <dloher@google.com>
* Changing cfg plugings to have option for batch and non batch gnmi.update --------- Co-authored-by: Darren Loher <dloher@google.com> Co-authored-by: Avnish Singh <singhavnish@google.com>
* Added deviation to Nokia: isis_mpls_unsupported * RT-5.6 Use loopback mode TERMINAL ref:PR1155 * . * . * Update interface_loopback_aggregate_test.go * Update interface_loopback_aggregate_test.go * fix RT-5.6: interface_loopback_aggregate --------- Co-authored-by: Swetha-haridasula <haridasula@google.com>
* added cli commands * fixing the ci/cd errors with go/static
* Added deviation to Nokia: isis_mpls_unsupported * RT-5.6 Use loopback mode TERMINAL ref:PR1155 * . * . * Update interface_loopback_aggregate_test.go * Update interface_loopback_aggregate_test.go * fix regex PLT-1.2: Parent component validation test --------- Co-authored-by: Swetha-haridasula <haridasula@google.com>
…4564) Co-authored-by: anksaiki <ankursaikia@google.com>
* Add functional test for gNMI leaf-list updates.
* (A) feature/gnmi/tests/leaflist_update_test/...
- Add a new functional test that validates the behaviour of
performing an update to a leaf-list via gNMI.
* Update README.md
* Update README.md
* Add required platform as vRX.
…oingContext(ctx) (#4574)
* deviation metadata * fixing typo * fixing typo * fixing typo
* Added deviation to Nokia: isis_mpls_unsupported * RT-5.6 Use loopback mode TERMINAL ref:PR1155 * . * . * Update interface_loopback_aggregate_test.go * Update interface_loopback_aggregate_test.go * fix gNMI-1.1: cli Origin * Addressing review comments --------- Co-authored-by: Swetha-haridasula <haridasula@google.com>
Co-authored-by: AmrNJ <155722765+AmrNJ@users.noreply.github.com>
* Adding PF-1.9 Egress handling of TTL Test
…#4534) * README for RT-10.1: Generate default route upon receiving a bgp route --------- Co-authored-by: Darren Loher <dloher@google.com>
* Update metadata.textproto * Update p4rt_election_test.go * Update p4rt_election_test.go * Update metadata.textproto * gofmt --------- Co-authored-by: Avnish Singh <singhavnish@google.com>
* fixing the tls_authentication_over_grpc_test.go * fixed static error related to unused functions * fixing the static error issue * fix static errors * fix static errors * fix static errors * fix static errors --------- Co-authored-by: Nikki Kumar <nikkikumar@google.com>
* (D) feature/gnmi/tests/gnimi_ni_test/* - Remove duplicate code that seems to have been incorrectly checked in.
* Creating device thruput test readme * changed location and comments addressed from darren * fixed tooplogy error * fixing metadata.textproto * fixing the comments from Darren * updated metadata.textproto * updating testregistry.textproto --------- Co-authored-by: Darren Loher <dloher@google.com>
* Optical-channel line-port OC path coverage in feature tests * Fix: Canonical OC validation error * Fix: go fmt issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the new openconfig-system-icmp-ext YANG module, which augments the base OpenConfig system model to expose configuration and operational state for ICMP Error Message Extensions as defined in RFC 5837.
Key Changes:
New Module: openconfig-system-icmp-ext.yang
Feature Parity: Adds knobs to enable/disable the inclusion of specific network interface details and next-hop information (e.g., ingress/egress interface name, index, sub-interface details, MTU) within generated ICMP Error Messages.
Telemetry: Introduces new counters under /state/counters to track:
Total ICMP error messages sent (total-messages-sent).
Total packets causing errors (total-error-pkts).
Total packets discarded without sending an ICMP error (total-discard-pkts).
This enhancement is critical for enabling operational troubleshooting and path tracing across the network, as it allows operators to identify the exact interface and next-hop that caused a packet discard or redirection.