Add SetOrigin validation to staticToBGP test

[sosdog]

Add SetOrigin validation to staticToBGP test

[OpenConfigBot]

Pull Request Functional Test Report for #5478 / bd50b8a

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		RT-1.27: Static route to BGP redistribution
Cisco 8000E		RT-1.27: Static route to BGP redistribution
Cisco XRd		RT-1.27: Static route to BGP redistribution
Juniper ncPTX		RT-1.27: Static route to BGP redistribution
Nokia SR Linux		RT-1.27: Static route to BGP redistribution
Openconfig Lemming		RT-1.27: Static route to BGP redistribution

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		RT-1.27: Static route to BGP redistribution
Cisco 8808		RT-1.27: Static route to BGP redistribution
Juniper PTX10008		RT-1.27: Static route to BGP redistribution
Nokia 7250 IXR-10e		RT-1.27: Static route to BGP redistribution

Help

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request expands the static-to-BGP redistribution test suite by adding validation for BGP route origin attributes. It introduces helper functions to configure routing policies with specific origin types and verifies that these attributes are correctly propagated and received by the ATE, ensuring compliance with BGP policy configurations for both IPv4 and IPv6.

Highlights

• New Test Cases: Added six new test cases (RT-1.27.23 to RT-1.27.28) to validate BGP route origin (IGP, EGP, INCOMPLETE) for both IPv4 and IPv6 static route redistribution.
• Helper Functions: Implemented redistributeStaticRoutePolicyWithRouteOrigin for test setup and validatePrefixRouteOrigin for verifying the BGP route origin attributes in the RIB.
• Documentation: Updated the test README to include the new test scenarios and updated the configuration parameter coverage list.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces new test cases (RT-1.27.23 to RT-1.27.28) to verify BGP route origin redistribution for IGP, EGP, and INCOMPLETE attributes across IPv4 and IPv6. The code changes include new configuration and validation helpers, as well as updated documentation. Feedback from the review highlights critical issues: the downgrade of traffic validation from fatal errors to log messages must be reverted to ensure test integrity, potential nil pointer panics in error handling paths need to be addressed, and BGP convergence timeouts should be increased to 30 seconds to prevent flakiness.

[sosdog]

updates from gemini checks.