Create openconfig-bgp-bmp.yang#1343
Conversation
Creating BGP BMP yang OC path definitions
|
No major YANG version changes in commit 7c29ae9 |
dplore
left a comment
dplore
left a comment
There was a problem hiding this comment.
Please add a .spec.yml file to ensure our CI tools and website will check and build this model. For example:
https://github.com/openconfig/public/blob/master/release/models/acl/.spec.yml
earies
left a comment
earies
left a comment
There was a problem hiding this comment.
Provided quick first pass - some overall comments
- Suggest looking at and providing reference implementations. There are various parameters not covered in this and would need to expand to accomodate. e.g. https://www.juniper.net/documentation/us/en/software/junos/cli-reference/topics/ref/statement/bmp-edit-routing-options.html
- Consider proper anchor points and NI relationships. Much of the OC modeling is often very loose allowing for combinations that are unrealistic or not supported so best to narrow that in
|
Also want to bring to attention some prior art/IETF modeling as reference/alignment. https://datatracker.ietf.org/doc/html/draft-ietf-grow-bmp-yang-05 |
|
Hi @vvlakshmanamurthy! Looking at the config, |
|
Discussed at OC Operators Meet Oct 07: (1) Seems like a lot of open comments; so, moving to waiting-for-author, |
ElodinLaarz
moved this from Ready to discuss
to Waiting for author
in OC Operator Review
Co-authored-by: Darren Loher <dloher@google.com>
Co-authored-by: Darren Loher <dloher@google.com>
Co-authored-by: Darren Loher <dloher@google.com>
Co-authored-by: Darren Loher <dloher@google.com>
Co-authored-by: Darren Loher <dloher@google.com>
Co-authored-by: Darren Loher <dloher@google.com>
Co-authored-by: Darren Loher <dloher@google.com>
vvlakshmanamurthy
left a comment
vvlakshmanamurthy
left a comment
There was a problem hiding this comment.
updating a few comments. few more comments to resolve.
vvlakshmanamurthy
left a comment
vvlakshmanamurthy
left a comment
There was a problem hiding this comment.
corrected trailing white spaces
updated models
edited and corrected
updated few corrections.
vvlakshmanamurthy
left a comment
vvlakshmanamurthy
left a comment
There was a problem hiding this comment.
updated few more corrections.
|
Fixed imports, removed duplicate nodes, fixed augments, created new tree view in PR description. |
|
Will review at May 12, 2026 OC Operators meeting |
|
Moved stations to only appear at the top level for bgp: ie: |
dplore
left a comment
dplore
left a comment
There was a problem hiding this comment.
@vvlakshmanamurthy few comments to respond to please. Thanks!
| leaf station-port { | ||
| type oc-inet:port-number; | ||
| description | ||
| "Thi is optional config at global/system level, the same can be defined at station level as well"; | ||
| } |
There was a problem hiding this comment.
This is redundant, but seems intentional? What do you do if the station has a port defined and then a different port is also defined at the global/peer/neighbor level? Which port do you use? Do we really need this flexibility and do vendors already support something like this?
| leaf station-network-instance { | ||
| type leafref { | ||
| path "/oc-netinst:network-instances/oc-netinst:network-instance/oc-netinst:name"; | ||
| } | ||
| description | ||
| "Thi is optional config at global/system level, the same can be defined at station level as well"; | ||
| } | ||
| } |
There was a problem hiding this comment.
This is redundant, but seems intentional? What do you do if the station has a network-instance defined and then a different network-instance is also defined at the global/peer/neighbor level? Which network-instance do you use? Do we really need this flexibility and do vendors already support something like this?
There was a problem hiding this comment.
How are the stations that are defined, linked to a global/peer/neighbor definition? Is it implied that all stations get streamed to? Or do we need a list of station names to be used in each global/peer/neighbor definition?
Please add at least two references to implementations of BMP |
7 participants
Creating BGP BMP yang OC path definitions
[Note: Please fill out the following template for your pull request. lines
tagged with "Note" can be removed from the template.]
[Note: Before this PR can be reviewed please agree to the CLA covering this
repo. Please also review the contribution guide -
https://github.com/openconfig/public/blob/master/doc/contributions-guide.md]
Change Scope
Platform Implementations
implementation output.
implementation output.
[Note: Please provide at least two references to implementations which are relevant to the model changes proposed. Each implementation should be from separate organizations.].
Tree view