Frontend quality: accessibility, loading UX, and chat error handling #703
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| import { cn } from "@/lib/utils"; | ||
|
|
||
| type AppLoadingPlaceholderProps = { | ||
| /** Announced to screen readers */ | ||
| message?: string; | ||
| className?: string; | ||
| /** Matches authenticated shell: sidebar stub + main pane */ | ||
| variant?: "app-shell" | "simple"; | ||
| }; | ||
|
|
||
| /** | ||
| * Accessible loading placeholder for route-level and auth-gated suspense states. | ||
| */ | ||
| export function AppLoadingPlaceholder({ | ||
| message = "Loading", | ||
| className, | ||
| variant = "simple", | ||
| }: AppLoadingPlaceholderProps) { | ||
| if (variant === "app-shell") { | ||
| return ( | ||
| <div | ||
| className={cn("flex h-screen w-full bg-sidebar", className)} | ||
| role="status" | ||
| aria-live="polite" | ||
| aria-busy="true" | ||
| > | ||
| <span className="sr-only">{message}</span> | ||
| <div className="w-64 shrink-0 bg-sidebar" aria-hidden="true" /> | ||
| <div className="flex-1 bg-background" aria-hidden="true" /> | ||
| </div> | ||
| ); | ||
| } | ||
|
|
||
| return ( | ||
| <div | ||
| className={cn("flex h-full w-full bg-background", className)} | ||
| role="status" | ||
| aria-live="polite" | ||
| aria-busy="true" | ||
| > | ||
| <span className="sr-only">{message}</span> | ||
| </div> | ||
| ); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -61,12 +61,13 @@ export function InlineErrorMessage({ error, onRetry }: InlineErrorMessageProps) | |||||||||||||||||||||||||||||
| return ( | ||||||||||||||||||||||||||||||
| <div className="w-full rounded-xl border border-destructive/30 bg-destructive/10 p-4"> | ||||||||||||||||||||||||||||||
| <div className="flex items-start gap-3"> | ||||||||||||||||||||||||||||||
| <div className="flex-shrink-0 mt-0.5" aria-hidden> | ||||||||||||||||||||||||||||||
| <svg | ||||||||||||||||||||||||||||||
| className="size-5 text-destructive" | ||||||||||||||||||||||||||||||
| fill="none" | ||||||||||||||||||||||||||||||
| viewBox="0 0 24 24" | ||||||||||||||||||||||||||||||
| stroke="currentColor" | ||||||||||||||||||||||||||||||
| aria-hidden | ||||||||||||||||||||||||||||||
| > | ||||||||||||||||||||||||||||||
| <path | ||||||||||||||||||||||||||||||
| strokeLinecap="round" | ||||||||||||||||||||||||||||||
|
|
@@ -85,8 +86,10 @@ export function InlineErrorMessage({ error, onRetry }: InlineErrorMessageProps) | |||||||||||||||||||||||||||||
| {error.details && ( | ||||||||||||||||||||||||||||||
| <div className="mt-2"> | ||||||||||||||||||||||||||||||
| <button | ||||||||||||||||||||||||||||||
| type="button" | ||||||||||||||||||||||||||||||
| onClick={() => setShowDetails(!showDetails)} | ||||||||||||||||||||||||||||||
| className="text-xs text-destructive/60 hover:text-destructive transition-colors" | ||||||||||||||||||||||||||||||
| aria-expanded={showDetails} | ||||||||||||||||||||||||||||||
| > | ||||||||||||||||||||||||||||||
| {showDetails ? "Hide details" : "Show details"} | ||||||||||||||||||||||||||||||
|
Comment on lines
88
to
94
Contributor
There was a problem hiding this comment.
Adding
Suggested change
And give the |
||||||||||||||||||||||||||||||
| </button> | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -170,10 +170,6 @@ export function ModelSelector({ | |
| e.preventDefault(); | ||
| handleClose(); | ||
| break; | ||
|
There was a problem hiding this comment. Tab removal leaves dropdown open with global key interceptionMedium Severity Removing the entire   |
||
| } | ||
| } | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -71,6 +71,7 @@ export function ModelItem({ | |
| : "text-muted-foreground/20 hover:text-amber-400 opacity-0 group-hover:opacity-100", | ||
| )} | ||
| title={isFavorite ? "Remove from favorites" : "Add to favorites"} | ||
| aria-label={isFavorite ? `Remove ${model.name} from favorites` : `Add ${model.name} to favorites`} | ||
| > | ||
| <StarIcon filled={isFavorite} className="size-4" /> | ||
| </button> | ||
|
|
@@ -117,6 +118,7 @@ export function ModelItem({ | |
| onInfoHover(); | ||
| }} | ||
| className="flex size-6 items-center justify-center rounded-md text-muted-foreground/40 transition-all duration-150 hover:text-foreground hover:bg-accent/80" | ||
| aria-label={`Model details for ${model.name}`} | ||
| > | ||
| <InfoIcon className="size-3.5" /> | ||
| </button> | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -265,6 +265,7 @@ describe("initial state shape", () => { | |
| expect(typeof result.current.retryMessage).toBe("function"); | ||
| expect(typeof result.current.forkMessage).toBe("function"); | ||
| expect(typeof result.current.stop).toBe("function"); | ||
| expect(typeof result.current.resetChatError).toBe("function"); | ||
| }); | ||
| }); | ||
|
|
||
|
|
@@ -411,6 +412,23 @@ describe("error tracking", () => { | |
| }); | ||
| expect(result.current.error).toBeUndefined(); | ||
| }); | ||
|
|
||
| it("resetChatError clears error and returns status from error to ready", async () => { | ||
| mockStartBackgroundStream.mockRejectedValueOnce(new Error("boom")); | ||
|
|
||
| const { result } = renderChat(); | ||
| await act(async () => { | ||
| await result.current.sendMessage({ text: "Hello" }); | ||
| }); | ||
| expect(result.current.status).toBe("error"); | ||
| expect(result.current.error).toBeTruthy(); | ||
|
|
||
| await act(async () => { | ||
| result.current.resetChatError(); | ||
| }); | ||
| expect(result.current.error).toBeUndefined(); | ||
| expect(result.current.status).toBe("ready"); | ||
| }); | ||
| }); | ||
|
|
||
| // --------------------------------------------------------------------------- | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| import { useCallback, useEffect, useRef, useState } from "react"; | ||
| import { useQuery } from "convex/react"; | ||
| import { api } from "@server/convex/_generated/api"; | ||
| import type { UIMessage } from "ai"; | ||
|
|
@@ -30,6 +30,8 @@ export interface UsePersistentChatReturn { | |
| chatId: string | null; | ||
| isResuming: boolean; | ||
| resumedContent: string; | ||
| /** Clears the last stream/send error and returns status from `error` to `ready` when applicable */ | ||
| resetChatError: () => void; | ||
| } | ||
|
|
||
| export function usePersistentChat({ | ||
|
|
@@ -84,6 +86,11 @@ export function usePersistentChat({ | |
| streamingRef, | ||
| }); | ||
|
|
||
| const resetChatError = useCallback(() => { | ||
| setError(undefined); | ||
| setStatus((prev) => (prev === "error" ? "ready" : prev)); | ||
| }, []); | ||
|
|
||
| const { sendMessage, editMessage, retryMessage, forkMessage } = useChatActions({ | ||
| convexUserId, | ||
| isUserLoading, | ||
|
|
@@ -117,5 +124,6 @@ export function usePersistentChat({ | |
| chatId: currentChatId, | ||
| isResuming, | ||
| resumedContent, | ||
| resetChatError, | ||
| }; | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aria-livealongsiderole="status"role="status"already carries an implicitaria-live="polite"mapping per the ARIA spec, so the explicitaria-live="polite"on lines 24 and 36 is redundant. It doesn't cause harm, but removing it keeps the markup cleaner.The same applies to the
simplevariant's container. Score: 2/5 — purely cosmetic, no functional impact.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!