Skip to content

Ignore corrections to documents as they come in an unintelligible format#36

Merged
tahmidrahman-dsi merged 1 commit intomainfrom
fix-document-corrections
Jan 15, 2026
Merged

Ignore corrections to documents as they come in an unintelligible format#36
tahmidrahman-dsi merged 1 commit intomainfrom
fix-document-corrections

Conversation

@tumbledwyer
Copy link
Contributor

Document corrections come in this form from v1, so they are not usable as correction values and when mapped, cause elasticsearch index issues.

           "input": [           
            {
              "valueCode": "documents",
              "valueId": "uploadDocForDeceased",
              "value": "Old Proof of deceased's ID",
              "__typename": "InputOutput"
            },
            {
              "valueCode": "documents",
              "valueId": "uploadDocForDeceasedDeath",
              "value": "Old Proof of death of deceased",
              "__typename": "InputOutput"
            }
          ],
          "output": [
            {
              "valueCode": "documents",
              "valueId": "uploadDocForDeceased",
              "value": "",
              "__typename": "InputOutput"
            },
            {
              "valueCode": "documents",
              "valueId": "uploadDocForDeceasedDeath",
              "value": "",
              "__typename": "InputOutput"
            }
          ],

Comment on lines +48 to +50
if (Object.keys(documentsResolver).includes(valueKey)) {
continue
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍🏼

@tahmidrahman-dsi tahmidrahman-dsi merged commit acf1162 into main Jan 15, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants