Skip to content

fix: Use Dialog instead of deprectaed ResponsiveModel#11768

Closed
jpye-finch wants to merge 7 commits intodevelopfrom
dialog-fix
Closed

fix: Use Dialog instead of deprectaed ResponsiveModel#11768
jpye-finch wants to merge 7 commits intodevelopfrom
dialog-fix

Conversation

@jpye-finch
Copy link
Copy Markdown
Contributor

Description

  • Assign dialog now uses Dialog and corrects the order of the buttons
  • Unassign dialog now uses Dialog
  • Event History dialog now uses Dialog

Checklist

  • I have linked the correct Github issue under "Development"
  • I have tested the changes locally, and written appropriate tests
  • I have tested beyond the happy path (e.g. edge cases, failure paths)
  • I have updated the changelog with this change (if applicable)
  • I have updated the GitHub issue status accordingly

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 6, 2026

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 6, 2026

ℹ️ Coverage metrics explained:
Statements — Executed code statements (basic logic lines)
Branches — Tested decision paths (if/else, switch, ternaries)
Functions — Functions invoked during tests
Lines — Source lines executed

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 6, 2026

📊 commons test coverage

Statements: 67.08%
Branches:   32.76%
Functions:  50%
Lines:      66.48%
Updated at: Thu, 12 Feb 2026 10:12:00 GMT

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 6, 2026

📊 events test coverage

Statements: 86.25%
Branches:   84.29%
Functions:  92.66%
Lines:      86.25%
Updated at: Thu, 12 Feb 2026 10:16:44 GMT

@jpye-finch jpye-finch changed the title fixes to dialogs fix: Use Dialog instead of deprectaed ResponsiveModel Feb 6, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 5, 2026

This PR has been marked with label stale Since it has been inactive for 20 days. It will automatically be closed in 10 days if no further activity occurs.

@github-actions github-actions Bot added the Stale The pr is inactive label Mar 5, 2026
@github-actions
Copy link
Copy Markdown

This PR has been automatically closed because it has been inactive for 30 days. Please reopen if you are still working on it.

@github-actions github-actions Bot closed this Mar 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Stale The pr is inactive

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants