fix(output): parse GUARDEX_COMPRESS_CMD with shell-quote awareness#650
Merged
NagyVikt merged 1 commit intoJun 18, 2026
Conversation
resolveCompressCommand split the command on whitespace, so a value with quoted args (e.g. sh -c "tr a-z A-Z") was mis-split into broken argv. Add tokenizeCommand: honors single/double quotes + backslash escapes, returns null on malformed input (unterminated quote or dangling backslash) so the caller falls back to plain, uncompressed output. argv still runs via spawnSync shell:false (no shell injection). Unset/plain values unchanged. Tests: +5 (quoted parsing, malformed->null, quoted end-to-end transform, deterministic timeout/partial-stdout fallback). 28 pass, 0 fail. Follow-up to #649.
NagyVikt
deleted the
agent/claude/harden-guardex-compress-cmd-shell-quote-2026-06-18-11-43
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated by gx branch finish (PR flow).