Conversation
added 7 commits
February 25, 2026 10:22
…e SSL handling and configuration
…ientFactory for improved clarity and maintainability
…ientFactory for improved clarity and maintainability
…ientFactory for improved clarity and maintainability
📊 Static Analysis Summary🔍 Code Quality Checks
📦 Download detailed reports from the workflow artifacts. |
Collaborator
jorge-romero
left a comment
jorge-romero
left a comment
There was a problem hiding this comment.
Have a look at the 2 comments, the cache need to be implemented in that way, the other point needs to be tested.
| * @throws BitbucketException if the instance is not configured | ||
| * @throws BitbucketException if the instance name is null/blank or not configured | ||
| */ | ||
| @Cacheable(value = "bitbucketApiClients", key = "#instanceName") |
Collaborator
There was a problem hiding this comment.
You need to add this, or there will be problems when someone tries to call it with a null value.
@Cacheable(value = "bitbucketApiClients", key = "#instanceName", condition = "#instanceName != null && !#instanceName.isBlank()")
| } catch (HttpClientErrorException.NotFound e) { | ||
| log.debug("Project '{}' does not exist in instance '{}'", projectKey, instanceName); | ||
| return false; | ||
|
|
Collaborator
There was a problem hiding this comment.
check if it is needed to catch when the token used is not valid (Unauthorized|Forbidden)
…le unauthorized access scenarios
📊 Static Analysis Summary🔍 Code Quality Checks
📦 Download detailed reports from the workflow artifacts. |
jorge-romero
approved these changes
Feb 27, 2026
angelmp01
deleted the
feature/EDPC-4280-bitbucket-service-project-existance
branch
BraisVQ
pushed a commit
that referenced
this pull request
Mar 3, 2026
Co-authored-by: EDPCommunity Automated Test <x2odsedpcomm@boehringer-ingelheim.com>
BraisVQ
pushed a commit
that referenced
this pull request
Mar 3, 2026
Co-authored-by: EDPCommunity Automated Test <x2odsedpcomm@boehringer-ingelheim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.