fix: wrap meaningful icons with text to improve screen reader output#770
Open
arbirali wants to merge 3 commits intoopenedx:masterfrom
Open
fix: wrap meaningful icons with text to improve screen reader output#770arbirali wants to merge 3 commits intoopenedx:masterfrom
arbirali wants to merge 3 commits intoopenedx:masterfrom
Conversation
Contributor
|
Please update the test cases. The required checks are failing. Other than that, the changes look good to me. |
|
Please post examples of the new text "visible" to screen reader users with this change in place. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On the Discussions page, screen reader–only text has been added to icons without labels, and aria-hidden="true" has been applied to icons that already have visible text.
Steps to reproduce:
Related to overhangio/tutor-indigo#146
How Has This Been Tested?
I set up Tutor locally with the Indigo plugin enabled (enabled by default) and followed the steps above to reproduce the issue. By inspecting the frontend HTML, I identified the required adjustment. After applying the fix, keyboard navigation using the Tab key now works correctly for both selected and non-selected options.
Screenshots/sandbox (optional):
Sandbox Link
Taiga Ticket (If someone have access)
Merge Checklist
Post-merge Checklist