Skip to content

Forbidden error provider#203

Merged
diana-villalvazo-wgu merged 4 commits into
openedx:mainfrom
WGU-Open-edX:feat/forbiddenErrorProvider
May 11, 2026
Merged

Forbidden error provider#203
diana-villalvazo-wgu merged 4 commits into
openedx:mainfrom
WGU-Open-edX:feat/forbiddenErrorProvider

Conversation

@diana-villalvazo-wgu
Copy link
Copy Markdown
Contributor

@diana-villalvazo-wgu diana-villalvazo-wgu commented May 11, 2026

Description

Now Instructor Dashboard checks if the calls to main instructor dash endpoint throws 401 or 403 to display correct messages if user is not allowed to see Instructor Content, we added a Provider wrapping the Main app and having an observer we can show the alert when needed

Supporting information

Closes #202

Testing instructions

Prev behavior
Screenshot 2026-05-11 at 12 52 50 p m

New behavior
401 user not signed in
Screenshot 2026-05-11 at 12 39 28 p m

403 student without instructor permissions
Screenshot 2026-05-11 at 12 40 36 p m

Other information

LLM usage notice

Built with assistance from Claude.

Best Practices Checklist

We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:

  • Any new files are using TypeScript (.ts, .tsx).
  • Deprecated propTypes, defaultProps, and injectIntl patterns are not used in any new or modified code.
  • Tests should use the helpers in src/testUtils.tsx (specifically initializeMocks)
  • Use React Query to load data from REST APIs. See any apiHooks.ts in this repo for examples.
  • All new i18n messages in messages.ts files have a description for translators to use.
  • Imports avoid using ../. To import from parent folders, use @src, e.g. import { initializeMocks } from '@src/testUtils'; instead of from '../../../../testUtils'

diana-villalvazo-wgu and others added 2 commits May 11, 2026 12:39
- Add ForbiddenErrorProvider context for global 403 error state management
- Integrate with existing AlertProvider for consistent error display
- Add internationalized error messages in English
- Automatically detect 403 errors in all API hooks (useCourseInfo, usePendingTasks, etc.)
- Hide tab content and navigation when forbidden error occurs
- Clear error state when navigating to different tabs
- Add comprehensive unit tests
- Update PageWrapper to include AlertOutlet for error display

Co-authored-by: Claude <claude@anthropic.com>
@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels May 11, 2026
@openedx-webhooks
Copy link
Copy Markdown

Thanks for the pull request, @diana-villalvazo-wgu!

This repository is currently maintained by @openedx/committers-frontend-app-instructor-dashboard.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions May 11, 2026
@diana-villalvazo-wgu diana-villalvazo-wgu force-pushed the feat/forbiddenErrorProvider branch 3 times, most recently from c579890 to 68b7670 Compare May 11, 2026 17:58
@diana-villalvazo-wgu diana-villalvazo-wgu moved this from Needs Triage to Ready for Review in Contributions May 11, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 11, 2026

Codecov Report

❌ Patch coverage is 96.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.52%. Comparing base (1e3d901) to head (cc27a29).

Files with missing lines Patch % Lines
src/providers/AccessErrorProvider.tsx 91.30% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #203      +/-   ##
==========================================
+ Coverage   90.42%   90.52%   +0.09%     
==========================================
  Files         141      145       +4     
  Lines        2466     2513      +47     
  Branches      549      555       +6     
==========================================
+ Hits         2230     2275      +45     
- Misses        228      230       +2     
  Partials        8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@diana-villalvazo-wgu diana-villalvazo-wgu force-pushed the feat/forbiddenErrorProvider branch from e7c49f0 to b90f40f Compare May 11, 2026 18:15
Comment thread src/data/apiHook.ts Outdated
Comment thread src/providers/ForbiddenErrorProvider.tsx Outdated
Comment thread src/providers/AccessErrorProvider.tsx
@diana-villalvazo-wgu diana-villalvazo-wgu merged commit 6881b77 into openedx:main May 11, 2026
6 checks passed
@github-project-automation github-project-automation Bot moved this from Ready for Review to Done in Contributions May 11, 2026
@diana-villalvazo-wgu diana-villalvazo-wgu deleted the feat/forbiddenErrorProvider branch May 11, 2026 22:08
diana-villalvazo-wgu added a commit to WGU-Open-edX/frontend-app-instructor-dashboard that referenced this pull request May 11, 2026
@openedx-semantic-release-bot
Copy link
Copy Markdown

🎉 This PR is included in version 1.0.0-alpha.40 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U released on @latest

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

General Error Message

5 participants