Skip to content

feat: add actions to attempts and fix missing attributes on table#204

Merged
diana-villalvazo-wgu merged 3 commits into
openedx:mainfrom
WGU-Open-edX:195/fix-attempts
May 13, 2026
Merged

feat: add actions to attempts and fix missing attributes on table#204
diana-villalvazo-wgu merged 3 commits into
openedx:mainfrom
WGU-Open-edX:195/fix-attempts

Conversation

@diana-villalvazo-wgu
Copy link
Copy Markdown
Contributor

@diana-villalvazo-wgu diana-villalvazo-wgu commented May 12, 2026

Description

As part of this PR were fixed:

  • Missing actions button with menu for resume/reset
  • Reset action when clicked
  • Missing type and exam name
  • Resume action shows up on error status

Supporting information

Closes #195

Screenshots

Screenshot 2026-05-12 at 5 26 30 p m Screenshot 2026-05-13 at 2 44 18 p m Screenshot 2026-05-13 at 2 44 11 p m Screenshot 2026-05-13 at 2 44 07 p m

Best Practices Checklist

We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:

  • Any new files are using TypeScript (.ts, .tsx).
  • Deprecated propTypes, defaultProps, and injectIntl patterns are not used in any new or modified code.
  • Tests should use the helpers in src/testUtils.tsx (specifically initializeMocks)
  • Use React Query to load data from REST APIs. See any apiHooks.ts in this repo for examples.
  • All new i18n messages in messages.ts files have a description for translators to use.
  • Imports avoid using ../. To import from parent folders, use @src, e.g. import { initializeMocks } from '@src/testUtils'; instead of from '../../../../testUtils'

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels May 12, 2026
@openedx-webhooks
Copy link
Copy Markdown

openedx-webhooks commented May 12, 2026

Thanks for the pull request, @diana-villalvazo-wgu!

This repository is currently maintained by @openedx/committers-frontend-app-instructor-dashboard.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions May 12, 2026
@diana-villalvazo-wgu diana-villalvazo-wgu force-pushed the 195/fix-attempts branch 2 times, most recently from e92bf0a to 7d12846 Compare May 12, 2026 19:56
@codecov
Copy link
Copy Markdown

codecov Bot commented May 12, 2026

Codecov Report

❌ Patch coverage is 98.86364% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 91.02%. Comparing base (a1d315c) to head (525ba16).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/specialExams/components/AttemptsList.tsx 95.65% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #204      +/-   ##
==========================================
+ Coverage   90.76%   91.02%   +0.25%     
==========================================
  Files         147      148       +1     
  Lines        2621     2708      +87     
  Branches      559      618      +59     
==========================================
+ Hits         2379     2465      +86     
+ Misses        236      235       -1     
- Partials        6        8       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@diana-villalvazo-wgu diana-villalvazo-wgu force-pushed the 195/fix-attempts branch 2 times, most recently from 9aaf82e to 01fac71 Compare May 12, 2026 22:08
@diana-villalvazo-wgu diana-villalvazo-wgu marked this pull request as ready for review May 12, 2026 22:23
@diana-villalvazo-wgu diana-villalvazo-wgu moved this from Needs Triage to Ready for Review in Contributions May 12, 2026
Comment thread src/specialExams/components/Attempts.tsx Outdated
Comment thread src/specialExams/types.ts Outdated
Comment thread src/specialExams/components/AttemptsList.tsx Outdated
Copy link
Copy Markdown
Contributor

@jacobo-dominguez-wgu jacobo-dominguez-wgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@diana-villalvazo-wgu diana-villalvazo-wgu merged commit 411ee13 into openedx:main May 13, 2026
6 checks passed
@github-project-automation github-project-automation Bot moved this from Ready for Review to Done in Contributions May 13, 2026
@diana-villalvazo-wgu diana-villalvazo-wgu deleted the 195/fix-attempts branch May 13, 2026 20:46
@openedx-semantic-release-bot
Copy link
Copy Markdown

🎉 This PR is included in version 1.0.0-alpha.42 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U released on @latest

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

fix: Exam Attempts

4 participants