Migrate from ObservableObject to @Observable (Swift Observation)#653
Migrate from ObservableObject to @Observable (Swift Observation)#653Demian-Yushyn wants to merge 53 commits intoopenedx:developfrom
Conversation
Fix/issue 581
Migrated Course Unit View, CourseContainerViewModel, SignInViewModel, BaseCourseViewModel
Swift, replacing `@ObservedObject` and `@StateObject`. This modernizes the data flow and simplifies the code by leveraging the compiler to automatically manage observation. Also it increases the minimum iOS deployment target to 17.0
Updates the iOS deployment target to version 17.0 in the project settings. Refactors the course outline and progress view to handle loading states correctly.
|
Thanks for the pull request, @Demian-Yushyn! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
This PR migrates ViewModels from the ObservableObject protocol and
@Publishedproperties to the new Swift Observation macro@Observable.As part of this change, the project now targets iOS 17+ as the minimum deployment version, allowing us to rely on modern SwiftUI and observation APIs without backward-compatibility workarounds.
Motivation
ObservableObject +
@Publishedrequires a significant amount of manual work and is error-prone:properties must be explicitly marked as
@Published, it’s easy to forget to publish changes, objectWillChange is implicit and not type-safe.With iOS 17 as the minimum supported version, we can safely adopt Swift’s
@Observablemacro, which provides a compiler-generated, first-class observation mechanism that is:What changed
Before
After
Benefits
@Published, or manual change notifications.