Skip to content

fix: Load from S3 button runs create instead#200

Merged
bmtcril merged 1 commit intomainfrom
bmtcril/fix_ui_s3
Sep 24, 2025
Merged

fix: Load from S3 button runs create instead#200
bmtcril merged 1 commit intomainfrom
bmtcril/fix_ui_s3

Conversation

@bmtcril
Copy link
Copy Markdown
Contributor

@bmtcril bmtcril commented Sep 23, 2025

  • A couple of fixes to UI mode. Clicking the button to load from S3 performed the "create" action instead.
  • Counters were not updating for loading xapi from S3
  • No message indicated that there were no files to load from the S3 location

)
self.go_button = urwid.Button(GO_TEXT, self.go_pressed)
self.load_button = urwid.Button(LOAD_TEXT, self.go_pressed)
self.load_button = urwid.Button(LOAD_TEXT, self.load_pressed)
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This prevented loading directly from S3 from working

@bmtcril bmtcril requested a review from saraburns1 September 24, 2025 14:17
@bmtcril bmtcril merged commit 46278ee into main Sep 24, 2025
4 checks passed
@bmtcril bmtcril deleted the bmtcril/fix_ui_s3 branch September 24, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants