-
Notifications
You must be signed in to change notification settings - Fork 25
fix: add transactions and isTransactionsEnabled to ClientWriteOptions #352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
curfew-marathon
wants to merge
5
commits into
main
Choose a base branch
from
fix/deprecate-disable-transactions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
a4540c6
fix: deprecate disableTransactions in favour of transactions and isTr…
curfew-marathon 3306f75
fix: use boolean primitive, rename internal field, add full Javadoc
curfew-marathon 0f1b259
fix: clarify transactions Javadoc — chunks are atomic individually, n…
curfew-marathon 244558f
fix: remove deprecation from disableTransactions, keep dual paths
curfew-marathon bb7bb42
Merge branch 'main' into fix/deprecate-disable-transactions
curfew-marathon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Enforce the chunk-size contract or relax the Javadoc.
Line 112 says the value “must be greater than zero”, but
transactionChunkSize(int)accepts0/negative values andgetTransactionChunkSize()silently converts them to1. That makes the public contract inaccurate and hides misconfiguration.Suggested fix
public ClientWriteOptions transactionChunkSize(int transactionChunkSize) { + if (transactionChunkSize <= 0) { + throw new IllegalArgumentException("transactionChunkSize must be greater than zero"); + } this.transactionChunkSize = transactionChunkSize; return this; }📝 Committable suggestion
🤖 Prompt for AI Agents