Skip to content

feat(dotnet-sdk): configurable client credentials token url#505

Open
alex-zyl wants to merge 1 commit into
openfga:mainfrom
alex-zyl:feature/238-configurable-token-issuer
Open

feat(dotnet-sdk): configurable client credentials token url#505
alex-zyl wants to merge 1 commit into
openfga:mainfrom
alex-zyl:feature/238-configurable-token-issuer

Conversation

@alex-zyl

@alex-zyl alex-zyl commented Mar 5, 2025

Copy link
Copy Markdown

Description

Makes token endpoint configurable.

References

#238

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@alex-zyl alex-zyl requested a review from a team as a code owner March 5, 2025 18:30
@linux-foundation-easycla

linux-foundation-easycla Bot commented Mar 5, 2025

Copy link
Copy Markdown

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: alex-zyl / name: Alex Zyl (a203e06)

@alex-zyl alex-zyl force-pushed the feature/238-configurable-token-issuer branch from 5231b3f to a203e06 Compare March 5, 2025 18:33
@rhamzeh rhamzeh self-assigned this Mar 17, 2025
@rhamzeh

rhamzeh commented Mar 17, 2025

Copy link
Copy Markdown
Member

Thanks for the PR @alex-zyl - sorry it's taking a bit longer to review, we're clearing through a backlog of .NET related changes and PRs and hopefully this week or early next week we can get this reviewed and merged

@alex-zyl

Copy link
Copy Markdown
Author

No worries, @rhamzeh

Luckily the issue with hardcoded token endpoint subpath can be workedaround by providing own instance of http client where we can overwrite request url

@jamp-scp28

Copy link
Copy Markdown

Hey @alex-zyl, just an opinion; but seems to me we're not addressing the root issue, a better solution should involve Discovery, it might require some work though.

On the other hand, if a workaround is to be provided, I think the PR might introduce edge cases and breaking changes on clients relying already on that PathTemplate; just and idea but why just not adding a new variable to the ClientConfiguration.Credentials and use it for the PathTemplate if not null?

@curfew-marathon

Copy link
Copy Markdown
Contributor

This PR has had no human activity for 90 days, so it has been marked lifecycle/stale.

This is automated backlog grooming, not a judgment on the work.

What happens next, unless there is activity:

  • In 30 days, it will move to lifecycle/closing-soon
  • 30 days after that, it will be closed

To keep it open, push a commit or leave a comment, and the clock will reset. For work that should not auto-close, such as an RFC or long-running experiment, ask a maintainer to add lifecycle/frozen.

@curfew-marathon curfew-marathon added the lifecycle/stale No human activity in 90 days label Jul 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lifecycle/stale No human activity in 90 days

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants