Remove redundant fga_client.close in python#545
Conversation
|
|
Please hold off on review. I'm realizing I still need to factor in changes from #116 |
Hi @davidroeca. While your refactoring and this PR is on hold, can you change it to |
fga_client.close() is handled by the context manager so it isn't needed, as discussed in openfga/python-sdk#191
f200d12 to
6826e93
Compare
|
Hi @dyeam0 that makes sense to me, but unfortunately I don't see a way to do so |
|
@davidroeca (for next time) it's from the side bar I marked it as draft for now - let us know when you believe is ready to review. Also please make sure to sign the Linux Foundation's CLA (#545 (comment)) when you are ready for it to be merged. It's a one time process, and without it we're restricted from merging. |
|
This PR has had no human activity for 90 days, so it has been marked This is automated backlog grooming, not a judgment on the work. What happens next, unless there is activity:
To keep it open, push a commit or leave a comment, and the clock will reset. For work that should not auto-close, such as an RFC or long-running experiment, ask a maintainer to add |


Description
fga_client.close()is handled by the context manager so it isn't needed, as discussed in openfga/python-sdk#191References
Review Checklist
main