Fix gamepad connect/disconnect event listener on HTML5#2062
Open
Digivorix wants to merge 1 commit into
Open
Conversation
The event listeners need to be added to Browser.window in order to work properly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gamepadconnected and gamepaddisconnected event listeners on HTML5 need to be added using
Browser.window.addEventListenerinstead ofelement.addEventListenerin order to work properly.Connected joysticks were still recognized, but it appears the event handler function in HTML5Window.hx (handleGamepadEvent) wasn't receiving any connect or disconnect events. As a consequence, the disconnect event for a connected gamepad would never fire.
Both the issue and the fix were tested in Firefox 150 and Microsoft Edge 148 on Windows 10 with a wireless Xbox 360 Controller connected via the official Wireless Receiver.