🐛(backend) enrollment and download agreement for batch orders#1342
Open
jonathanreveille wants to merge 2 commits into
Open
🐛(backend) enrollment and download agreement for batch orders#1342jonathanreveille wants to merge 2 commits into
jonathanreveille wants to merge 2 commits into
Conversation
jonathanreveille
changed the title
jonathanreveille
changed the title
jonathanreveille
changed the title
jonathanreveille
changed the title
jonathanreveille
force-pushed
the
hotfix/batch_order_enroll_student_purchase_order_contract_not_signed
branch
from
773369c to
43566f7
Compare
Since we have changed the behavior of when the orders are generated for a batch order with purchase order payment method, we forgot to update the enrollment clean method, where it would check whether the contract related is signed or not. With purchase order method, we generate the orders before the contract is signed. This would block the orders generated and the student to access the course because their enrollment would fail.
We've updated the download and retrieve endpoint for the `OrganizationAgreementViewSet`. Now, batch order owners can retrieve their agreement once fully signed in pdf format.
jonathanreveille
force-pushed
the
hotfix/batch_order_enroll_student_purchase_order_contract_not_signed
branch
from
43566f7 to
a83b79d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix enrollments from batch order with purchase order method for student to enroll when the contract is not yet signed.
Fix on download action and permissions of an agreement from the owner's dashboard.
Proposal
Enrollmentmodelget_querysetinOrganizationAgreementViewSet