Open
Conversation
In addition to being up-to-date, this removes the need to have and pin `fake-factory` becauses uses the replacement `faker`.
`3.6.4` is the last version working without changes. 3.7 needs change about using django-filter instead of previously integrated feature in drf.
Before upgrading 4+, it was recommended to upgrade to 3.1.25.
`rest_framework.filters` is removed in `3.7` and replaced by `django_filters.rest_framework`.
In DFR 3.8, it's not possible anymore to have read-only fields in serializers having a default value set on creation. For this, there is `CreateOnlyDefault`, so we use this for `VideoUploadUrlSerializer.expires_at`
They will be required in Django 2. The actual default is `CASCADE` so we set the arg to this value, it implies no changes.
To solve this that will break when migrating to Django 2 https://docs.djangoproject.com/en/dev/releases/1.9/#passing-a-3-tuple-or-an-app-name-to-include ```bash $ python -Wd manage.py check api/urls.py:4: RemovedInDjango20Warning: Specifying a namespace in django.conf.urls.include() without providing an app_name is deprecated. Set the app_name attribute in the included module, or pass a 2-tuple containing the list of patterns and app_name instead. url(r'^v1/', include('api.v1.urls', namespace="v1")), videofront/urls.py:8: RemovedInDjango20Warning: Specifying a namespace in django.conf.urls.include() without providing an app_name is deprecated. Set the app_name attribute in the included module, or pass a 2-tuple containing the list of patterns and app_name instead. url(r'^api/', include('api.urls', namespace="api")), ```
http://django-filter.readthedocs.io/en/latest/guide/migration.html#filter-name-renamed-to-filter-field-name ``` $ python -Wd manage.py check api/v1/views.py:181: DeprecationWarning: `Filter.name` has been renamed to `Filter.field_name`. See: https://django-filter.readthedocs.io/en/develop/migration.html playlist_id = django_filters.CharFilter(name="playlists", lookup_expr="public_id") ```
http://www.django-rest-framework.org/topics/3.8-announcement/#action-decorator-replaces-list_route-and-detail_route ``` $ python -Wd manage.py check api/v1/views.py:68: PendingDeprecationWarning: `detail_route` is pending deprecation and will be removed in 3.10 in favor of `action`, which accepts a `detail` bool. Use `@action(detail=True)` instead. @detail_route(methods=['POST']) api/v1/views.py:82: PendingDeprecationWarning: `detail_route` is pending deprecation and will be removed in 3.10 in favor of `action`, which accepts a `detail` bool. Use `@action(detail=True)` instead. @detail_route(methods=['POST']) api/v1/views.py:266: PendingDeprecationWarning: `detail_route` is pending deprecation and will be removed in 3.10 in favor of `action`, which accepts a `detail` bool. Use `@action(detail=True)` instead. @detail_route(methods=['POST']) api/v1/views.py:302: PendingDeprecationWarning: `detail_route` is pending deprecation and will be removed in 3.10 in favor of `action`, which accepts a `detail` bool. Use `@action(detail=True)` instead. @detail_route(methods=['POST']) api/v1/views.py:351: PendingDeprecationWarning: `detail_route` is pending deprecation and will be removed in 3.10 in favor of `action`, which accepts a `detail` bool. Use `@action(detail=True)` instead. @detail_route(methods=['POST', 'OPTIONS']) ```
"session authentication" is enabled by default in django 1.10 so `SessionAuthenticationMiddleware` was not needed anymore. And removed in django 2.
We use `assert_called_once` which is only present in python 3.6
twidi
force-pushed
the
upgrade-requirements
branch
from
566001a to
8907c6a
Compare
twidi
force-pushed
the
upgrade-requirements
branch
from
8907c6a to
fe0be1e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I first checked the dependencies that could be upgraded
Them filtered this list (manually) to only include the ones in our requirement files.:
At the end we have this:
And limited to our requirements:
The only reason for not upgrading to celery 4 is that there are some important changes and I don't know this library enough (in fact I don't know it at all) to carry this change on my own.
So everything else is ok, but celery (still upgraded to the last version before 4).
One thing: on an existing environment, I had to uninstall
fake-factoryANDfactory-boybefore reinstallingfactory-boyto the last version.