Draft
Conversation
We'll need this to cope with pint's unit definition syntax.
We'll want to be line-for-line compatible to maximize our ability to stand on Pint's shoulders, here.
Make a naive implementation that is just enough to test the construction of record-type quantities with a partial in a separate project. Currently this has zero protection against unregistered units, or implementation of arithmetic or conversion. Going down a record-based implementation to experiment with getting the faster dispatch (that ought to be possible) over the older vector-based tuple implementation.
Seems we need to implement IEquiv as well for node + browser repl
For kilo, milli, etc. Following pint's definition convention.
Just rely on the clojure one.
Without this guard, clojurescript equality checks can blow up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every one of our projects seems to require a slightly different set of units. A central concept in Pint is user-definable registries. Let's bring that in, and make the
make-quantityfn take a unit registry as its first argument so that the validation, etc. can vary per project.Proposed API: