Skip to content

RVVILogger Module to RVVI TEXT format for coverage#1632

Open
SadhviNarayanan wants to merge 4 commits into
openhwgroup:mainfrom
SadhviNarayanan:rvvilogger_new
Open

RVVILogger Module to RVVI TEXT format for coverage#1632
SadhviNarayanan wants to merge 4 commits into
openhwgroup:mainfrom
SadhviNarayanan:rvvilogger_new

Conversation

@SadhviNarayanan
Copy link
Copy Markdown
Contributor

@SadhviNarayanan SadhviNarayanan commented Jan 25, 2026

This is the rvvilogger module to convert rvvitrace interface data into rvvitext format, so we can get coverage from Wally. I have also attached a sample objdump and rvvitext output, and the rvvitext document passes the python script.

Sm_rvvi_trace.txt
Sm.txt

@jordancarlin
Copy link
Copy Markdown
Member

This is still marked as a draft. Is it ready for a review?

@SadhviNarayanan SadhviNarayanan marked this pull request as ready for review February 10, 2026 16:47
@davidharrishmc
Copy link
Copy Markdown
Contributor

@jordancarlin ping

@jordancarlin
Copy link
Copy Markdown
Member

Sorry for the delay in reviewing! Can you please update to version 0.3 of the RVVI-Text spec (I don't recall how that differs from what you have here, but you list the version as 0.1). Once it's updated, I'll put this at the top of my list to review.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a new rvviTextLogger module that converts data from the RVVI-TRACE interface (rvviTrace) into RVVI-TEXT format, intended for use with functional coverage tools. It is instantiated alongside the existing wallyTracer inside the ENABLE_RVVI_TRACE guard in testbench.sv. The module writes a conforming RVVI-TEXT header and one trace line per retired instruction, capturing PC, instruction encoding, GPR/FPR/vector/CSR state changes, mode transitions, interrupts, and halts.

Changes:

  • New file testbench/common/rvviTextLogger.sv: Full implementation of the RVVI-TEXT serialiser module.
  • testbench/testbench.sv: Instantiation of rvviTextLogger connected to the shared rvvi interface.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 9 comments.

File Description
testbench/common/rvviTextLogger.sv New module that reads from the rvviTrace interface and writes a standards-compliant RVVI-TEXT trace file
testbench/testbench.sv Adds rvviTextLogger instantiation under ENABLE_RVVI_TRACE guard, connected to the existing rvvi interface

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread testbench/common/rvviTextLogger.sv
Comment thread testbench/common/rvviTextLogger.sv Outdated
Comment thread testbench/common/rvviTextLogger.sv
Comment thread testbench/common/rvviTextLogger.sv Outdated
Comment thread testbench/common/rvviTextLogger.sv Outdated
Comment thread testbench/common/rvviTextLogger.sv Outdated
Comment thread testbench/common/rvviTextLogger.sv Outdated
Comment thread testbench/common/rvviTextLogger.sv
Comment thread testbench/common/rvviTextLogger.sv
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread testbench/common/rvviTextLogger.sv
Comment thread testbench/common/rvviTextLogger.sv
Comment thread testbench/common/rvviTextLogger.sv Outdated
Comment thread testbench/testbench.sv
Comment thread testbench/common/rvviTextLogger.sv
Copy link
Copy Markdown
Member

@jordancarlin jordancarlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass of comments. Many of the Copilot comments are also valid, so please address those too and then let me know when you are ready for another review.

Comment thread testbench/common/rvviTextLogger.sv Outdated
Comment thread testbench/common/rvviTextLogger.sv Outdated
Comment thread testbench/common/rvviTextLogger.sv Outdated
Comment thread testbench/common/rvviTextLogger.sv Outdated
Comment thread testbench/common/rvviTextLogger.sv Outdated
Comment thread testbench/common/rvviTextLogger.sv Outdated
Comment thread testbench/common/rvviTextLogger.sv
Comment thread testbench/common/rvviTextLogger.sv Outdated
Comment thread testbench/common/rvviTextLogger.sv Outdated
Comment thread testbench/common/rvviTextLogger.sv Outdated
@davidharrishmc
Copy link
Copy Markdown
Contributor

Is this close to ready?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants