RVVILogger Module to RVVI TEXT format for coverage#1632
RVVILogger Module to RVVI TEXT format for coverage#1632SadhviNarayanan wants to merge 4 commits into
Conversation
|
This is still marked as a draft. Is it ready for a review? |
|
@jordancarlin ping |
|
Sorry for the delay in reviewing! Can you please update to version 0.3 of the RVVI-Text spec (I don't recall how that differs from what you have here, but you list the version as 0.1). Once it's updated, I'll put this at the top of my list to review. |
There was a problem hiding this comment.
Pull request overview
This PR introduces a new rvviTextLogger module that converts data from the RVVI-TRACE interface (rvviTrace) into RVVI-TEXT format, intended for use with functional coverage tools. It is instantiated alongside the existing wallyTracer inside the ENABLE_RVVI_TRACE guard in testbench.sv. The module writes a conforming RVVI-TEXT header and one trace line per retired instruction, capturing PC, instruction encoding, GPR/FPR/vector/CSR state changes, mode transitions, interrupts, and halts.
Changes:
- New file
testbench/common/rvviTextLogger.sv: Full implementation of the RVVI-TEXT serialiser module. testbench/testbench.sv: Instantiation ofrvviTextLoggerconnected to the sharedrvviinterface.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 9 comments.
| File | Description |
|---|---|
testbench/common/rvviTextLogger.sv |
New module that reads from the rvviTrace interface and writes a standards-compliant RVVI-TEXT trace file |
testbench/testbench.sv |
Adds rvviTextLogger instantiation under ENABLE_RVVI_TRACE guard, connected to the existing rvvi interface |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jordancarlin
left a comment
There was a problem hiding this comment.
First pass of comments. Many of the Copilot comments are also valid, so please address those too and then let me know when you are ready for another review.
|
Is this close to ready? |
This is the rvvilogger module to convert rvvitrace interface data into rvvitext format, so we can get coverage from Wally. I have also attached a sample objdump and rvvitext output, and the rvvitext document passes the python script.
Sm_rvvi_trace.txt
Sm.txt