fix: Added many checks to flash-sd.sh to prevent regular files from being created accidentally where a block device was supposed to be.#1778
Open
JacobPease wants to merge 4 commits into
Conversation
…eing created accidentally where a block device was supposed to be.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR strengthens linux/sdcard/flash-sd.sh safety checks to reduce the risk of accidentally creating regular files in /dev when a block device (SD card) was intended, by validating the target device and related partition nodes before flashing.
Changes:
- Introduces additional device identification (
DEVNAME) and sysfs size-based checks to detect “no card inserted” scenarios. - Adds validation that the target path (and any existing partition-like paths) are block devices, failing fast otherwise.
- Makes GPT info printing conditional on detecting partitions.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…device type is a whole-disk. Cleaned up checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves #1614 by adding extra checks for the block device. This will prevent accidentally creating regular files instead of block device partitions when an SD card is not inserted and present in the block device.